Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve time and use waitForSelector in auto-login tests #4603

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request includes three commits that improve the test time and replace timeouts with wait for selectors in the autoLogin test.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 14, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Nov 14, 2024
@ogabrielluiz ogabrielluiz changed the title refactor: Improve test time and wait for selectors instead of timeouts refactor: Improve time and use waitForSelector in auto-login tests Nov 14, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Nov 14, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 14, 2024
@ogabrielluiz ogabrielluiz force-pushed the improveTimeAutoLoginTest branch from 9184a5a to 2d6699e Compare November 14, 2024 16:31
@ogabrielluiz ogabrielluiz merged commit 349a1fe into main Nov 14, 2024
18 checks passed
@ogabrielluiz ogabrielluiz deleted the improveTimeAutoLoginTest branch November 14, 2024 16:56
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…angflow-ai#4603)

* improve usage of waitForSelector

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants