ref: Add ruff rules for pylint (PL) #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
cbornet
commented
Oct 6, 2024
| @@ -1525,7 +1525,7 @@ async def _execute_tasks(self, tasks: list[asyncio.Task], lock: asyncio.Lock) -> | |||
| for t in tasks[i + 1 :]: | |||
| t.cancel() | |||
| raise result | |||
| if isinstance(result, tuple) and len(result) == 5: | |||
| if isinstance(result, tuple) and len(result) == 5: # TODO: what 5 corresponds to ? | |||
There was a problem hiding this comment.
@ogabrielluiz do you know what this corresponds to ?
There was a problem hiding this comment.
possibly related to the size of the result of this method:
There was a problem hiding this comment.
The tuple shall be VertexBuildResult. I fixed it. PTAL.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
cbornet
changed the title
ogabrielluiz
requested changes
Oct 7, 2024
| @@ -26,7 +28,7 @@ class UpdateDataComponent(Component): | |||
| info="Number of fields to be added to the record.", | |||
| real_time_refresh=True, | |||
| value=0, | |||
| range_spec=RangeSpec(min=1, max=15, step=1, step_type="int"), | |||
| range_spec=RangeSpec(min=1, max=MAX_NUMBER_OF_FIELDS, step=1, step_type="int"), | |||
There was a problem hiding this comment.
Gotta be careful with this because we currently do not eval variables outside the class unless they are import statements
ogabrielluiz
reviewed
Oct 8, 2024
Comment on lines
+1528
to
+1529
| if isinstance(result, VertexBuildResult): | ||
| vertices.append(result.vertex) |
There was a problem hiding this comment.
This makes sense, I just don't know how it was working before.
ogabrielluiz
approved these changes
Oct 8, 2024
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
* Add ruff rules for pylint (PL) * Changes following review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ruff rules for pylint (PL)