ci: fix releases with uv #3971
Merged
ci: fix releases with uv #3971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
jordanrfrazier
commented
Oct 2, 2024
|
|
||
| - name: Test CLI | ||
| run: | | ||
| python -m pip install src/backend/base/dist/*.whl | ||
| python -m langflow run --host 127.0.0.1 --port 7860 & | ||
| # TODO: unsure why the whl is not built in src/backend/base |
There was a problem hiding this comment.
I have no idea why this behavior changed on me. Between pushes, through no change on my end that I can tell, make build base using uv started putting the base whl into root/dist instead of root/src/backend/base/dist. This is a hack that moves it back to where everything else expects it to be.
dosubot
bot
added
the
size:L
jordanrfrazier
commented
Oct 2, 2024
jordanrfrazier
commented
Oct 2, 2024
| - name: Wait for PyPI Propagation | ||
| run: sleep 300 # wait for 5 minutes to ensure PyPI propagation of base | ||
|
|
||
| - name: Build project for distribution | ||
| run: make build main=true args="--no-sources" | ||
| run: make build main=true args="--no-sources --wheel" |
There was a problem hiding this comment.
only building wheel, no sdist
NadirJ
approved these changes
Oct 2, 2024
ogabrielluiz
force-pushed
the
fraz-nightly-uv
branch
from
56fef67 to
e9f6e20
Compare
ogabrielluiz
added
lgtm
- Introduced `actions/checkout@v4` step to multiple workflows to ensure code is checked out at a specific ref. - Updated `.github/workflows/docker-build.yml`, `.github/workflows/release_nightly.yml`, `.github/workflows/lint-py.yml`, and `.github/workflows/style-check-py.yml` to include the new checkout step. - Ensured credentials are persisted during the checkout process.
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
* Update scripts * update the base dep in uv deps * update nightly scripts * Add uv creds for publish * skip tests for now * fix version * only build the wheel * try again * add uv to python run * [autofix.ci] apply automated fixes * use uv cache * more version fixe * fixing versions * fix base version * Try no frozen? * skip everything to try docker build * tag * frozen * separate script for updating uv dep * [autofix.ci] apply automated fixes * hardcoded versions * hardcoded versions * add version to editable package * build project before docker file runs * try again * fix uv patht o build * don't know why this would mkae a difference * debug statements * debug statements * debug statements * change path to whl 🤷 * manually move the wheel... * make dir * try no sources * add back tests * refactor uv to action * add uv action * Update nightly build workflow to include uv lock files in version update commit * Update lint-py workflow to use specific ref for setup-uv action * Add checkout step to style-check-py GitHub Actions workflow * Remove redundant GitHub ref syntax in lint-py.yml workflow * Update lint-py.yml to use specific ref for setup-uv action * Update action.yml: standardize quotes and remove redundant checkout step * Add checkout step to GitHub Actions workflows for specific ref handling - Introduced `actions/checkout@v4` step to multiple workflows to ensure code is checked out at a specific ref. - Updated `.github/workflows/docker-build.yml`, `.github/workflows/release_nightly.yml`, `.github/workflows/lint-py.yml`, and `.github/workflows/style-check-py.yml` to include the new checkout step. - Ensured credentials are persisted during the checkout process. * Add checkout step to Python test workflow with specific ref --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly fixes up the releases and nightlies to work with
uv. The dockerbasebuild is still broken, though themainis able to build and pulls correctly (tested with nightlies - https://hub.docker.com/r/langflowai/langflow-nightly).Also, I do not build the source distributions. I tried, but the resulting tarball was ~300mb. Unsure what we need to prune there - have tried
--no-sources.The best workflow is https://github.com/langflow-ai/langflow/actions/runs/11136444977/job/30948508609 - all passing except base docker push.
That said, unless someone notices the issue with the base docker build, I propose we merge this now to unblock releases then fix the docker base image in a follow up.