fix: Store inference model name in model call span

langdb · Feb 11, 2025 · bbedf30 · bbedf30
1 parent f6ce1d4
commit bbedf30
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/core/src/executor/chat_completion/mod.rs b/core/src/executor/chat_completion/mod.rs
@@ -126,7 +126,7 @@ pub async fn execute(
     };
 
     let completion_model_definition = CompletionModelDefinition {
-        name: request.model.clone(),
+        name: format!("{}/{}", llm_model.model_provider, llm_model.model),
         model_params: CompletionModelParams {
             engine: engine.clone(),
             provider_name: llm_model.model_provider.to_string(),

diff --git a/core/src/model/mod.rs b/core/src/model/mod.rs
@@ -304,13 +304,15 @@ impl<Inner: ModelInstance> ModelInstance for TracedModel<Inner> {
         let model_name = self.definition.name.clone();
         let provider_name = self.definition.db_model.provider_name.clone();
         let (tx, mut rx) = channel::<Option<ModelEvent>>(outer_tx.max_capacity());
-        // let json_value_tags = JsonValue(&serde_json::to_value(tags_1.clone())?).as_value();
+
         let span = info_span!(
             target: "langdb::user_tracing::models",
             SPAN_MODEL_CALL,
             input = &input_str,
             model = model_str,
             provider_name = provider_name,
+            model_name = model_name.clone(),
+            inference_model_name = self.definition.db_model.name.to_string(),
             output = tracing::field::Empty,
             error = tracing::field::Empty,
             credentials_identifier = credentials_ident.to_string(),
@@ -420,6 +422,8 @@ impl<Inner: ModelInstance> ModelInstance for TracedModel<Inner> {
             input = &input_str,
             model = model_str,
             provider_name = provider_name,
+            model_name = model_name.clone(),
+            inference_model_name = self.definition.db_model.name.to_string(),
             output = tracing::field::Empty,
             error = tracing::field::Empty,
             credentials_identifier = credentials_ident.to_string(),