Clone dataset schema #1278
Merged
Clone dataset schema #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakerachleff
suggested changes
Dec 3, 2024
| @@ -3283,6 +3284,8 @@ def clone_public_dataset( | |||
| dataset_name=dataset_name, | |||
| description=ds.description, | |||
| data_type=ds.data_type or ls_schemas.DataType.kv, | |||
| inputs_schema=ds.inputs_schema, | |||
There was a problem hiding this comment.
can we set transformations as well here?
jakerachleff
reviewed
Dec 3, 2024
| The description of the dataset. | ||
| data_type : DataType or None, default=DataType.kv | ||
| data_type : ls_schemas.DataType, default=ls_schemas.DataType.kv |
There was a problem hiding this comment.
note to self to mark this as deprecated
jakerachleff
reviewed
Dec 3, 2024
| @@ -171,6 +171,22 @@ class Config: | |||
| frozen = True | |||
|
|
|||
|
|
|||
| DatasetTransformationType = Literal[ | |||
There was a problem hiding this comment.
Any thoughts on not making this a literal so it's easier to add new ones server side?
There was a problem hiding this comment.
I think since I union with str it at least won't be blocked if you try to say a new one
jakerachleff
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.