fix(js): Fix multipart upload with overridden node fetch #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfcampos
reviewed
Nov 20, 2024
| }, | ||
| body: formData, | ||
| body: arrayBuffer, |
There was a problem hiding this comment.
Will fetch automatically set content length header from array buffer length?
There was a problem hiding this comment.
It works so I assumed it wasn't necessary but will populate
There was a problem hiding this comment.
Claude says:
Note: In many cases, modern HTTP clients and the Fetch API will automatically set the correct Content-Length header when you provide a body. You could also remove the Content-Length header entirely and let the client handle it automatically.
It seems to work in tests with native fetch and Node fetch, and I wasn't doing it before - can manually populate if preferred
nfcampos
reviewed
Nov 20, 2024
nfcampos
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.