Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary protected keyword in a few places #743

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

nfcampos
Copy link
Collaborator

These things made up by TS can sometimes be more harm than good sadly, as they don't really protect anything for anyone using JS without TS, and can create strange typing issues

@nfcampos nfcampos requested a review from agola11 April 11, 2023 14:26
@vercel
Copy link

vercel bot commented Apr 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 11, 2023 2:26pm

@nfcampos nfcampos merged commit 98d32f3 into main Apr 11, 2023
@nfcampos nfcampos deleted the nc/ts-simplify branch April 11, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant