Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update pdf_qa.ipynb #7137

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

apuravchauhan
Copy link
Contributor

@apuravchauhan apuravchauhan commented Nov 1, 2024

Refer the correct variable name

In the tutorial the, llm is instantiated under the variable name model. But while creating the createStuffDocumentsChain in the following steps, the variable name referred is llm.

The issue comes in because the variable llm exists in python documentation and the same is copied here in js documentation
Fixes # (issue)

Refer the correct variable name
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 1, 2024
Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Nov 5, 2024 4:34am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Nov 5, 2024 4:34am

@dosubot dosubot bot added the auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder label Nov 1, 2024
@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 changed the title Update pdf_qa.ipynb docs: Update pdf_qa.ipynb Nov 5, 2024
@jacoblee93 jacoblee93 merged commit 338a668 into langchain-ai:main Nov 5, 2024
5 of 6 checks passed
cinqisap pushed a commit to cinqisap/langchainjs that referenced this pull request Nov 6, 2024
Co-authored-by: Jacob Lee <jacoblee93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants