feat(community): ElasticVectorSearch: add a not_exists filter #7036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:nit
|
Looks good - could you add an integration test illustrating desired behavior? |
dosubot
bot
added
size:S
Sure, I've added/adapted the tests! |
|
Thank you! |
jacoblee93
changed the title
My pleasure, thank you for taking your time! |
cdierkens
pushed a commit
to cdierkens/langchainjs
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently implemented a new functionality in our application where the customer is able to archive items.
As we want to exclude archived items by default from our vectorstore search we need a filter to add a statement to the must_not filtering being a must_not exists and then we pass
{ field: 'archivedAt', operator: 'not_exists' }.If we then want to include archived items later one, we can just not pass this filter.
I think by adding this custom check, we add a lot of flexibility to the similarity search as well.