Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): Added AWS Bedrock Document and Image Support #6956

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

MNorgren
Copy link
Contributor

@MNorgren MNorgren commented Oct 9, 2024

Currently, Amazon Bedrock supports text, images and documents in their Converse API.

It appears that the langchain-aws (the python version), has added support for both of these message content types:

This change adds support for both type === 'document' and type === 'image' per the Converse API examples.

Fixes #6955

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Oct 11, 2024 9:26pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Oct 11, 2024 9:26pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Oct 9, 2024
@MNorgren
Copy link
Contributor Author

@jacoblee93 or @bracesproul - I see you gentlemen often contributing, so I thought I'd reach out. I am wondering if there is anything else I need to do for a Pull Request? I went through the formal documentation, but I am not sure about the review process. I use LangChain quite heavily with AWS Bedrock and Azure Open AI; hopefully become more engaged with this project.

Blessings!

@MNorgren MNorgren changed the title Added AWS Bedrock Document and Image Support feat(aws): Added AWS Bedrock Document and Image Support Oct 11, 2024
@jacoblee93
Copy link
Collaborator

No sorry just bogged down with other things! Thank you for this, will review as soon as possible 🙏

@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Oct 11, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 11, 2024
@jacoblee93 jacoblee93 merged commit 8a5aee5 into langchain-ai:main Oct 11, 2024
26 checks passed
CarterMorris pushed a commit to CarterMorris/langchainjs that referenced this pull request Nov 10, 2024
…#6956)

Co-authored-by: Michael Norgren <michael@solidrockcoding.com>
Co-authored-by: jacoblee93 <jacoblee93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants