Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ollama): Drop tool_choice from docstrings #6905

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix(ollama): Drop tool_choice from docstrings #6905

merged 1 commit into from
Sep 30, 2024

Conversation

bracesproul
Copy link
Member

@vercel Vercel
Copy link

vercel bot commented Sep 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 10:01pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Sep 30, 2024 10:01pm

@bracesproul
Copy link
Member Author

Closes #6897

@bracesproul bracesproul marked this pull request as ready for review September 30, 2024 21:50
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Sep 30, 2024
@jacoblee93 jacoblee93 merged commit 7d23c54 into main Sep 30, 2024
26 checks passed
@jacoblee93
Copy link
Collaborator

Thanks!

@jacoblee93 jacoblee93 deleted the brace/drop-tool-choice-ollama branch September 30, 2024 22:22
FilipZmijewski pushed a commit to FilipZmijewski/langchainjs that referenced this pull request Oct 1, 2024
@bracesproul @FilipZmijewski
fix(ollama): Drop tool_choice from docstrings (langchain-ai#6905)
8b7e68c
@langchain-ai langchain-ai locked as spam and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bracesproul @jacoblee93