fix(community): bump @upstash/ratelimit version
#6832
+19
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
size:XS
|
Flagging that this will break existing users for people using |
jacoblee93
reviewed
Sep 17, 2024
| @@ -148,7 +148,7 @@ class UpstashRatelimitHandler extends BaseCallbackHandler { | |||
| _name?: string | |||
| ): Promise<void> { | |||
| if (this.tokenRatelimit) { | |||
| const remaining = await this.tokenRatelimit.getRemaining(this.identifier); | |||
| const { remaining } = await this.tokenRatelimit.getRemaining(this.identifier); | |||
There was a problem hiding this comment.
May be some way to make this backwards compatible and allow "^1.1.3 || ^2.0.3" in deps above
There was a problem hiding this comment.
I changed the code so that it works in both versions.
I didn't understand how the package.json should be updated, can you explain a bit more?
There was a problem hiding this comment.
@CahidArda I just pushed up a commit allowing those versions
dosubot
bot
added
size:S
bracesproul
changed the title
@upstash/ratelimit version
bracesproul
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping Upstash Ratelimit version to benefit from the number of improvements we have made.