fix(anthropic): Do not check for apiKey existence when createClient parameters are present #6716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
size:XS
|
Thank you! Good catch, sorry for missing this. |
jacoblee93
reviewed
Sep 10, 2024
| @@ -949,7 +949,7 @@ export class ChatAnthropicMessages< | |||
| ): Promise<Anthropic.Message> { | |||
| if (!this.batchClient) { | |||
| const options = this.apiUrl ? { baseURL: this.apiUrl } : undefined; | |||
| if (!this.apiKey) { | |||
| if (!this.apiKey && !this.createClient) { | |||
There was a problem hiding this comment.
I think this.createClient will always be defined since we have a default - can update
There was a problem hiding this comment.
Honestly, I don't really think we need a second check here. Will remove.
This was referenced Sep 12, 2024
This was referenced Sep 14, 2024
This was referenced Oct 3, 2024
This was referenced Oct 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6615 (comment)