core[patch]: Prevent ConsoleCallbackHandler from throwing TypeError when logging #6612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, when `onToolEnd` is called, it assumed the value of `run.outputs.output` is always of type `string`. In cases when it wasn't a string, this would cause a `TypeError` to be thrown. Note that it appeared that the same issue could occur in `onToolStart`, so I corrected that case as well.
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:bug
|
Ah thank you! |
jacoblee93
changed the title
This was referenced Sep 7, 2024
This was referenced Sep 12, 2024
This was referenced Sep 14, 2024
This was referenced Oct 3, 2024
This was referenced Oct 5, 2024
CarterMorris
pushed a commit
to CarterMorris/langchainjs
that referenced
this pull request
Nov 10, 2024
…hen logging (langchain-ai#6612) Co-authored-by: jacoblee93 <jacoblee93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when
onToolEndis called, it assumed the value ofrun.outputs.outputis always of typestring. In cases when it wasn't a string, this would cause aTypeErrorto be thrown.Note that it appeared that the same issue could occur in
onToolStart, so I corrected that case as well.