Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws[patch]: Fix fails when calling multiple tools simultaneously #6175

Merged
merged 3 commits into from
Jul 23, 2024
Merged

aws[patch]: Fix fails when calling multiple tools simultaneously #6175

merged 3 commits into from
Jul 23, 2024

Conversation

tinque
Copy link
Contributor

@tinque tinque commented Jul 23, 2024

Fixes #6173

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 23, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 7:08pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jul 23, 2024 7:08pm

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Jul 23, 2024
@tinque
Copy link
Contributor Author

tinque commented Jul 23, 2024

I've made a dirty fix that works... any ideas on how to do this more cleanly?

@jacoblee93 jacoblee93 requested a review from bracesproul July 23, 2024 01:23
bracesproul
bracesproul reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, it would be great to have a test confirming this too. Could you add one inside libs/langchain-aws/src/tests/chat_models.test.ts which imports this function, passes an array of messages and expects the messages to be in the proper format?

Thank you!

libs/langchain-aws/src/common.ts Outdated Show resolved Hide resolved
@bracesproul bracesproul marked this pull request as draft July 23, 2024 17:05
@tinque
Copy link
Contributor Author

tinque commented Jul 23, 2024

I've completed the test and refactored it slightly. Is this okay with you?

@bracesproul bracesproul marked this pull request as ready for review July 23, 2024 18:48
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 23, 2024
bracesproul
bracesproul approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Going to get this merged & released now

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jul 23, 2024
@bracesproul bracesproul merged commit 87d92d9 into langchain-ai:main Jul 23, 2024
30 checks passed
@tinque tinque deleted the fix/6173 branch July 23, 2024 19:23
@prathik2401 prathik2401 mentioned this pull request Aug 15, 2024
Merged
@riderx riderx mentioned this pull request Aug 18, 2024
Closed
@sam2177142 sam2177142 mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@langchain/aws Bug: ChatBedrockConverse fails when calling multiple tools simultaneously
2 participants
@tinque @bracesproul