Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mistral[minor]: Populate usage metadata for mistral #5751

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

bracesproul
Copy link
Member

adds streaming tokens support

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 4:40pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 4:40pm

@bracesproul bracesproul marked this pull request as ready for review June 13, 2024 01:10
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Jun 13, 2024
@@ -389,6 +427,8 @@ export class ChatMistralAI<

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I've reviewed the code and noticed that the added line doesn't interact with environment variables, but the constructor does access an environment variable using the getEnvironmentVariable function. I've flagged this for your review. Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant