google-genai[patch]: Fix removing additional properties from schema (#…

…6109)

* google-genai[patch]: Fix removing additional properties from schema

* chore: lint files

libs/langchain-google-genai/src/tests/chat_models.test.ts

@@ -15,6 +15,19 @@ import {
   convertMessageContentToParts,
 } from "../utils/common.js";
 
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+function extractKeys(obj: Record<string, any>, keys: string[] = []) {
+  for (const key in obj) {
+    if (Object.prototype.hasOwnProperty.call(obj, key)) {
+      keys.push(key);
+      if (typeof obj[key] === "object" && obj[key] !== null) {
+        extractKeys(obj[key], keys);
+      }
+    }
+  }
+  return keys;
+}
+
 test("Google AI - `temperature` must be in range [0.0,1.0]", async () => {
   expect(
     () =>
@@ -89,19 +102,6 @@ test("Google AI - `safetySettings` category array must be unique", async () => {
 });
 
 test("removeAdditionalProperties can remove all instances of additionalProperties", async () => {
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  function extractKeys(obj: Record<string, any>, keys: string[] = []) {
-    for (const key in obj) {
-      if (Object.prototype.hasOwnProperty.call(obj, key)) {
-        keys.push(key);
-        if (typeof obj[key] === "object" && obj[key] !== null) {
-          extractKeys(obj[key], keys);
-        }
-      }
-    }
-    return keys;
-  }
-
   const idealResponseSchema = z.object({
     idealResponse: z
       .string()
@@ -137,6 +137,26 @@ test("removeAdditionalProperties can remove all instances of additionalPropertie
   expect(
     arrSchemaObj.find((key) => key === "additionalProperties")
   ).toBeUndefined();
+
+  const analysisSchema = z.object({
+    decision: z.enum(["UseAPI", "UseFallback"]),
+    explanation: z.string(),
+    apiDetails: z
+      .object({
+        serviceName: z.string(),
+        endpointName: z.string(),
+        parameters: z.record(z.unknown()),
+        extractionPath: z.string(),
+      })
+      .optional(),
+  });
+  const parsedAnalysisSchema = removeAdditionalProperties(
+    zodToJsonSchema(analysisSchema)
+  );
+  const analysisSchemaObj = extractKeys(parsedAnalysisSchema);
+  expect(
+    analysisSchemaObj.find((key) => key === "additionalProperties")
+  ).toBeUndefined();
 });
 
 test("convertMessageContentToParts correctly handles message types", () => {

libs/langchain-google-genai/src/utils/zod_to_genai_parameters.ts

@@ -24,10 +24,7 @@ export function removeAdditionalProperties(
   if (typeof obj === "object" && obj !== null) {
     const newObj = { ...obj };
 
-    if (
-      "additionalProperties" in newObj &&
-      typeof newObj.additionalProperties === "boolean"
-    ) {
+    if ("additionalProperties" in newObj) {
       delete newObj.additionalProperties;
     }