typo bugfixes in getting started with prompts #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provided code doesn't run, because the keys are `word` and `antonym`, rather than `input` and `output`. Also, the `ExampleSelector`-based prompt is named `few_shot_prompt` when defined and `dynamic_prompt` in the follow-up example. The former name is less descriptive and collides with an earlier example, so I opted for the latter. Thanks for making a really cool library!
Blaizzy
added a commit
to Blaizzy/langchain
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: input -> word, output -> antonym, rename to dynamic_prompt consistently
The provided code in this example doesn't run, because the keys are
wordandantonym, rather thaninputandoutput.Also, the
ExampleSelector-based prompt is namedfew_shot_promptwhen defined anddynamic_promptin the follow-up example. The former name is less descriptive and collides with an earlier example, so I opted for the latter.Thanks for making a really cool library!