-
Notifications
You must be signed in to change notification settings - Fork 16k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full Google Drive features. #5135
Conversation
139d499
to
d44c2b0
Compare
@vowelparrot I have 3 workflow awaitings approval. You must accept to start these jobs? |
d44c2b0
to
8096caf
Compare
I'd gladly collaborate on improving Google Drive support on LangChain. The above test failled since googleapiclient is a new requirement for poetry.lock. |
6327ab2
to
417957c
Compare
I resolve this problem. I test the github action in my branch, and now all workflow are correct. |
Sorry. I fix the format now. It's not possible to start by hand, the workflow lint |
99b664e
to
cea2563
Compare
@eyurtsev Can you run the workflows to validate this version ? |
After this pull-request, I will normalize the link with google token, to use one scope for google drive, gmail, etc. |
@eyurtsev, can you active the workflows, and if all is correct, can you review this code? |
@eyurtsev, sorry for the last error. |
6acba43
to
fa2c3ac
Compare
@eyurtsev, I have a question about my implementation. In the method _lazy_load_file_from_file(), I had an optional run_manager.
But the code is not clean. Do you have a better idea? I initiate the possibility to use a lazy approach in the retriever.
The default implementation transforms a classic list of documents to an iterator. But, the subclasses can be choice to implements a lazy approach, to optimize the memory footprint. In my Google Drive utilities, I use a lazy approach. Later, I would like to update the link between the loaders and vectordb, to use a lazy approach if it's possible. Then, a loader can return a big number of documents to import, without problems with the memory. |
fa2c3ac
to
c45dde5
Compare
The code changes every day, so I must make rebase another time. @eyurtsev, If you star the workflows quickly, all will be correct ;-) |
Hello @hwchase17, Thanks |
e0f3248
to
ac8f85e
Compare
@hwchase17, @eyurtsev, I rebase my code with the last version. |
ac8f85e
to
5270738
Compare
Hello @eyurtsev, @hwchase17, I'm sure you've got plenty of pull requests to validate. |
3fe3262
to
1153b38
Compare
1153b38
to
9e68719
Compare
9e68719
to
9965d37
Compare
Hello @eyurtsev, @hwchase17, @vowelparrot, @baskaryan and @hinthornw, Can someone contact me via discord, to organize a commented review, if that would make things easier? |
1d4caf4
to
6d460f0
Compare
6d460f0
to
b67063c
Compare
9a4f1fb
to
e8182c9
Compare
My other [pull-request](#5135) is too big to be acceptable. I propose another 'lite' version. I update only notebook to propose an integration with the external project [`langchain-googledrive`](https://github.com/pprados/langchain-googledrive). --------- Co-authored-by: Harrison Chase <hw.chase.17@gmail.com>
manage headers, table, links and bullet
Add tables and link
e8182c9
to
c9538b5
Compare
Reimplement the Google Drive features
Propose :
Features:
Recognition
If you accept my pull-request, you can mention me @pprados. Thanks
Before submitting
Unit-tests coverage >80% of new code
No integration test, but some notebook to show how to use.
Who can review?
Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested:
@eyurtsev @hwchase17 @vowelparrot might be interested