Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openai, deepseek: make _convert_chunk_to_generation_chunk an instance method #29731

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

ccurme
Copy link
Collaborator

@ccurme ccurme commented Feb 11, 2025

  1. Make _convert_chunk_to_generation_chunk an instance method on BaseChatOpenAI
  2. Override on ChatDeepSeek to add "reasoning_content" to message additional_kwargs.

Resolves #29513

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 11, 2025
Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 5:11pm

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 11, 2025
@ccurme ccurme merged commit 9477f49 into master Feb 11, 2025
54 checks passed
@ccurme ccurme deleted the cc/deepseek_stream_reasoning_content branch February 11, 2025 19:13
bluearrow98 pushed a commit to bluearrow98/langchain that referenced this pull request Feb 13, 2025
… method (langchain-ai#29731)

1. Make `_convert_chunk_to_generation_chunk` an instance method on
BaseChatOpenAI
2. Override on ChatDeepSeek to add `"reasoning_content"` to message
additional_kwargs.

Resolves langchain-ai#29513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Cannot retrieve reasoning_content while streaming
2 participants