Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: add min version testing to pr test flow #24358

Merged
merged 10 commits into from
Jul 19, 2024

Conversation

efriis
Copy link
Member

@efriis efriis commented Jul 17, 2024

xfailing some sql tests that do not currently work on sqlalchemy v1

#22207 was very much not sqlalchemy v1 compatible.

Moving forward, implementations should be compatible with both to pass CI

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jul 19, 2024 9:52pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Jul 17, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jul 19, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 19, 2024
@efriis efriis enabled auto-merge (squash) July 19, 2024 21:49
@efriis efriis disabled auto-merge July 19, 2024 21:49
@efriis efriis enabled auto-merge (squash) July 19, 2024 21:54
@efriis efriis merged commit f4ee3c8 into master Jul 19, 2024
99 checks passed
@efriis efriis deleted the erick/infra-add-min-version-testing-to-pr-test-flow branch July 19, 2024 22:03
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
xfailing some sql tests that do not currently work on sqlalchemy v1

langchain-ai#22207 was very much not sqlalchemy v1 compatible. 

Moving forward, implementations should be compatible with both to pass
CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant