GraphCypherQAChain: Dynamic inputs cypher generation #24300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e inputs for cypher generation
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
community
eyurtsev
reviewed
Jul 18, 2024
| "question": question, | ||
| "schema": self.graph_schema, | ||
| } | ||
| args.update(inputs) |
There was a problem hiding this comment.
Does args.update not duplicate the question content? under the key self.input_key
Is there any unit test you could write?
There was a problem hiding this comment.
That's a good question, regarding the content duplication, if the input_key for the question is different than "question" it will indeed duplicate because the default template uses "question" and I cant guarantee that the user didn't specified other cypher_prompt template.
At the end of the day will not impact if it duplicate.
But give me your feedback on this.
eyurtsev
approved these changes
Jul 19, 2024
dosubot
bot
added
the
lgtm
|
@eyurtsev should I include tests for more edge cases? I can open another PR. Give your feedback on this. |
olgamurraft
pushed a commit
to olgamurraft/langchain
that referenced
this pull request
Aug 16, 2024
…rovided by the user for cypher generation (langchain-ai#24300) **Description:** This PR introduces a change to the `cypher_generation_chain` to dynamically concatenate inputs. This improvement aims to streamline the input handling process and make the method more flexible. The change involves updating the arguments dictionary with all elements from the `inputs` dictionary, ensuring that all necessary inputs are dynamically appended. This will ensure that any cypher generation template will not require a new `_call` method patch. **Issue:** This PR fixes issue langchain-ai#24260.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR introduces a change to the
cypher_generation_chainto dynamically concatenate inputs. This improvement aims to streamline the input handling process and make the method more flexible. The change involves updating the arguments dictionary with all elements from theinputsdictionary, ensuring that all necessary inputs are dynamically appended. This will ensure that any cypher generation template will not require a new_callmethod patch.Issue: This PR fixes issue #24260.