Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix elastic rag template in playground #12682

Merged
merged 7 commits into from
Nov 1, 2023
Merged

fix elastic rag template in playground #12682

merged 7 commits into from
Nov 1, 2023

Conversation

efriis
Copy link
Member

@efriis efriis commented Oct 31, 2023 •
edited
Loading

  • a few instructions in the readme (load_documents -> ingest.py)
  • added docker run command for local elastic
  • adds input type definition to render playground properly

@vercel Vercel
Copy link

vercel bot commented Oct 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Nov 1, 2023 0:17am

@dosubot dosubot bot added 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature 🔌: elasticsearch Primarily related to elastic/elasticsearch integrations labels Oct 31, 2023
@efriis efriis changed the title fix elastic rag template fix elastic rag template in playground Oct 31, 2023
@efriis efriis requested a review from rlancemartin October 31, 2023 23:16
efriis
efriis commented Nov 1, 2023
View reviewed changes
templates/chat-bot-feedback/chat_bot_feedback/chain.py
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new lint ci didnt like this

@efriis efriis merged commit b825ddd into master Nov 1, 2023
7 checks passed
@efriis efriis deleted the erick/fix-elastic-template branch November 1, 2023 00:18
xieqihui pushed a commit to xieqihui/langchain that referenced this pull request Nov 21, 2023
@efriis @xieqihui
fix elastic rag template in playground (langchain-ai#12682)
7e78462 
- a few instructions in the readme (load_documents -> ingest.py)
- added docker run command for local elastic
- adds input type definition to render playground properly
hoanq1811 pushed a commit to hoanq1811/langchain that referenced this pull request Feb 2, 2024
@efriis
fix elastic rag template in playground (langchain-ai#12682)
ede6c13 
- a few instructions in the readme (load_documents -> ingest.py)
- added docker run command for local elastic
- adds input type definition to render playground properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlancemartin rlancemartin Awaiting requested review from rlancemartin

Assignees
No one assigned
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature 🔌: elasticsearch Primarily related to elastic/elasticsearch integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@efriis