Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install and use ruff format instead of black for code formatting. #12585

Merged
merged 13 commits into from
Oct 31, 2023
Merged

Install and use ruff format instead of black for code formatting. #12585

merged 13 commits into from
Oct 31, 2023

Conversation

obi1kenobi
Copy link
Collaborator

Best to review one commit at a time, since two of the commits are 100% autogenerated changes from running ruff format:

  • Install and use ruff format instead of black for code formatting.
  • Output of ruff format . in the langchain package.
  • Use ruff format in experimental package.
  • Format changes in experimental package by ruff format.
  • Manual formatting fixes to make ruff . pass.

@vercel
Copy link

vercel bot commented Oct 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 2:47pm

@dosubot dosubot bot added the 🤖:refactor A large refactor of a feature(s) or restructuring of many files label Oct 30, 2023
baskaryan
baskaryan reviewed Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@baskaryan baskaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a root level Makefile as well that should be updated

@obi1kenobi obi1kenobi requested a review from baskaryan October 30, 2023 21:17
@obi1kenobi
Copy link
Collaborator Author

Planning to remove the black cache setup and associated complexity from the lint script in a separate PR, just to limit the review complexity here.

@obi1kenobi obi1kenobi mentioned this pull request Oct 30, 2023
Merged
@obi1kenobi
Copy link
Collaborator Author

Will resolve the conflict and merge.

@obi1kenobi obi1kenobi merged commit f94e24d into master Oct 31, 2023
38 checks passed
@obi1kenobi obi1kenobi deleted the pg/use-ruff-format branch October 31, 2023 14:53
obi1kenobi added a commit that referenced this pull request Nov 1, 2023
@obi1kenobi
Remove black caching config from CI lint workflow. (#12594)
724b922 
To merge after #12585 is merged.
xieqihui pushed a commit to xieqihui/langchain that referenced this pull request Nov 21, 2023
@obi1kenobi @xieqihui
Install and use ruff format instead of black for code formatting. (l…
7d28d1a 
…angchain-ai#12585)

Best to review one commit at a time, since two of the commits are 100%
autogenerated changes from running `ruff format`:
- Install and use `ruff format` instead of black for code formatting.
- Output of `ruff format .` in the `langchain` package.
- Use `ruff format` in experimental package.
- Format changes in experimental package by `ruff format`.
- Manual formatting fixes to make `ruff .` pass.
xieqihui pushed a commit to xieqihui/langchain that referenced this pull request Nov 21, 2023
@obi1kenobi @xieqihui
Remove black caching config from CI lint workflow. (langchain-ai#12594
c04a826 
)

To merge after langchain-ai#12585 is merged.
hoanq1811 pushed a commit to hoanq1811/langchain that referenced this pull request Feb 2, 2024
@obi1kenobi
Install and use ruff format instead of black for code formatting. (l…
ec0db63 
…angchain-ai#12585)

Best to review one commit at a time, since two of the commits are 100%
autogenerated changes from running `ruff format`:
- Install and use `ruff format` instead of black for code formatting.
- Output of `ruff format .` in the `langchain` package.
- Use `ruff format` in experimental package.
- Format changes in experimental package by `ruff format`.
- Manual formatting fixes to make `ruff .` pass.
hoanq1811 pushed a commit to hoanq1811/langchain that referenced this pull request Feb 2, 2024
@obi1kenobi
Remove black caching config from CI lint workflow. (langchain-ai#12594
fe45eb2 
)

To merge after langchain-ai#12585 is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser left review comments

@baskaryan baskaryan baskaryan approved these changes

@nfcampos nfcampos Awaiting requested review from nfcampos

@eyurtsev eyurtsev Awaiting requested review from eyurtsev

Assignees
No one assigned
Labels
🤖:refactor A large refactor of a feature(s) or restructuring of many files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obi1kenobi @MichaReiser @baskaryan