Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add truncate argument for Cohere's LLM #1256

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Add truncate argument for Cohere's LLM #1256

merged 2 commits into from
Feb 24, 2023

Conversation

stepp1
Copy link
Contributor

@stepp1 stepp1 commented Feb 23, 2023

As #798, this commit adds the option to truncate the user's inputs larger than what the model can handle.

This defaults to None in the Cohere SDK instead of directly passing "NONE", so I maintained the same default value (see: https://github.com/cohere-ai/cohere-python/blob/7f30bfd40c98b88f7d08f8c05db5b91ddb1310d1/cohere/client.py#L127)

PS: I think that both this and #798 should default to the same value.

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - will update the embedding one as well

@hwchase17 hwchase17 changed the base branch from master to harrison/cohere-params February 24, 2023 15:20
@hwchase17 hwchase17 merged commit 999d5b2 into langchain-ai:harrison/cohere-params Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants