feat: Add page metadata on PDFMinerLoader #12277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: doc loader
hwchase17
reviewed
Oct 25, 2023
|
@blue-hope this looks good, but we'd want to add a parameter in the init controlled by end users to make sure that we can retain backwards compatibility for this parser |
|
@hwchase17 @eyurtsev I added the feature flag |
eyurtsev
reviewed
Oct 30, 2023
eyurtsev
reviewed
Nov 1, 2023
libs/langchain/tests/integration_tests/document_loaders/test_pdf.py
Outdated
Show resolved
Hide resolved
libs/langchain/tests/integration_tests/document_loaders/test_pdf.py
Outdated
Show resolved
Hide resolved
eyurtsev
approved these changes
Nov 1, 2023
eyurtsev
added
the
lgtm
xieqihui
pushed a commit
to xieqihui/langchain
that referenced
this pull request
Nov 21, 2023
- **Description:** langchain-ai#12273 's suggestion PR Like other PDFLoader, loading pdf per each page and giving page metadata. - **Issue:** langchain-ai#12273 - **Twitter handle:** @blue0_0hope --------- Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDFMinerLoadernot givespagemetadata when loading withextract_images=False- is it intended? #12273 's suggestion PRLike other PDFLoader, loading pdf per each page and giving page metadata.
PDFMinerLoadernot givespagemetadata when loading withextract_images=False- is it intended? #12273