Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quip loader #12259

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Add quip loader #12259

merged 6 commits into from
Oct 31, 2023

Conversation

shufanhao
Copy link
Contributor

@shufanhao shufanhao commented Oct 25, 2023 •
edited
Loading

@vercel
Copy link

vercel bot commented Oct 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2023 2:24am

@dosubot dosubot bot added Ɑ: doc loader Related to document loader module (not documentation) 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Oct 25, 2023
@shufanhao
Copy link
Contributor Author

@eyurtsev can you help to take a look ?

hwchase17
hwchase17 reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also add an example notebook in the integrations documentation

libs/langchain/langchain/document_loaders/quip.py Outdated
from typing import List, Optional
from xml.etree.ElementTree import ElementTree

from PIL import Image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should all be imported conditionally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, update.

@shufanhao
Copy link
Contributor Author

we should also add an example notebook in the integrations documentation

added.

@shufanhao
Copy link
Contributor Author

@hwchase17 can you help to take a look ?

@shufanhao
Copy link
Contributor Author

thank you @baskaryan

@baskaryan baskaryan added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Oct 31, 2023
@baskaryan baskaryan merged commit bf5805b into langchain-ai:master Oct 31, 2023
23 checks passed
@baskaryan
Copy link
Collaborator

thanks @shufanhao!

@shufanhao
Copy link
Contributor Author

@baskaryan when the new package can be released ?

xieqihui pushed a commit to xieqihui/langchain that referenced this pull request Nov 21, 2023
@shufanhao @baskaryan @xieqihui
Add quip loader (langchain-ai#12259)
4715bb5 
- **Description:** implement [quip](https://quip.com) loader
  - **Issue:** langchain-ai#10352
  - **Dependencies:** No
  -  pass make format, make lint, make test

---------

Co-authored-by: Hao Fan <h_fan@apple.com>
Co-authored-by: Bagatur <baskaryan@gmail.com>
hoanq1811 pushed a commit to hoanq1811/langchain that referenced this pull request Feb 2, 2024
@shufanhao @baskaryan
Add quip loader (langchain-ai#12259)
5d1a44c 
- **Description:** implement [quip](https://quip.com) loader
  - **Issue:** langchain-ai#10352
  - **Dependencies:** No
  -  pass make format, make lint, make test

---------

Co-authored-by: Hao Fan <h_fan@apple.com>
Co-authored-by: Bagatur <baskaryan@gmail.com>
@Goldabj
Copy link

Goldabj commented Feb 2, 2024

Does this still work? I'm not able to fine a quip-api in the pip index?

@didn0t
Copy link

didn0t commented May 7, 2024

Does this still work? I'm not able to fine a quip-api in the pip index?

I'm not sure if it ever was, there is this version https://github.com/dvwright/quipclient/tree/master.

Perhaps the langchain module should be updated to use this instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchase17 hwchase17 hwchase17 left review comments

Assignees
No one assigned
Labels
Ɑ: doc loader Related to document loader module (not documentation) 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shufanhao @baskaryan @Goldabj @didn0t @hwchase17