Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TOTP Authenticator support to client #70

Closed
14 tasks done
lanedirt opened this issue Jun 27, 2024 · 0 comments · Fixed by #182
Closed
14 tasks done

Add TOTP Authenticator support to client #70

lanedirt opened this issue Jun 27, 2024 · 0 comments · Fixed by #182
Labels
enhancement New feature or request
Milestone
Usability / UX po...

Comments

@lanedirt
Copy link
Owner

lanedirt commented Jun 27, 2024 •
edited
Loading

  • Add 2FA login to Admin app (template already provided options)
  • Add 2FA to client app login before syncing client database
  • Force 2FA to be required on admin app, or at least highlight it on every page if it isn't set yet.
  • Check possibiltiy to make it generic so we can support it both for logging in to AliasVault itself and for credentials to store the OTP token there and generate a OTP token for that specific credential.

For client flow:

  • When 2FA is enabled, require 2FA when logging in on the machine for the first time. Next, as long as the JWT refresh token stays valid 2FA is not required anymore. So for login 2FA is always required, but for unlock not.
  • Add E2E test that verifies the create user, setup 2FA, login with 2FA required flow.

Extend admin settings:

  • Add option to disable 2FA for specific user.

Extend client settings screen with:

  • Check if 2FA is currently enabled for user.
  • If enabled: show option to revoke existing 2FA and setup with new key.
  • Add recovery codes output after enabling authenticator app for recovery purposes.
  • Make recovery code input step work during login.
  • Add admin option to reset authenticator keys in case user authenticator got compromised.
  • Add E2E tests for recovery codes.
  • Refactor API auth and client login to reduce duplicate code.
@lanedirt lanedirt added the enhancement New feature or request label Jun 27, 2024
@lanedirt lanedirt added this to the Usability / UX polishing milestone Aug 16, 2024
@lanedirt lanedirt moved this to Ready in AliasVault Aug 16, 2024
@lanedirt lanedirt changed the title Add TOTP Authenticator support Add TOTP Authenticator support to client Aug 19, 2024
lanedirt added a commit that referenced this issue Aug 23, 2024
@lanedirt
Update install.sh (#70)
7aeb34e
lanedirt added a commit that referenced this issue Aug 23, 2024
@lanedirt
Add working basic 2FA login flow to client (#70)
f7865e5
lanedirt added a commit that referenced this issue Aug 23, 2024
@lanedirt
Add E2E test for client two-factor auth setup (#70)
e058990
lanedirt added a commit that referenced this issue Aug 23, 2024
@lanedirt
Add unittests for TotpGenerator logic (#70)
0df0b2c
lanedirt added a commit that referenced this issue Aug 23, 2024
@lanedirt
Add admin option to disable 2FA for user (#70)
8ba039f
lanedirt added a commit that referenced this issue Aug 23, 2024
@lanedirt
Add persistent 2FA warning to admin app if 2FA is not set (#70)
1db9fa5
@lanedirt lanedirt moved this from Ready to In progress in AliasVault Aug 23, 2024
lanedirt added a commit that referenced this issue Aug 24, 2024
@lanedirt
Refactor two-factor auth setup in client (#70)
329281c
lanedirt added a commit that referenced this issue Aug 26, 2024
@lanedirt
Add recovery code support to client 2FA login flow (#70)
9ef078b
@lanedirt lanedirt mentioned this issue Aug 26, 2024
Open
lanedirt added a commit that referenced this issue Aug 26, 2024
@lanedirt
Add E2E test for 2-FA recovery codes (#70)
f6f33c2
lanedirt added a commit that referenced this issue Aug 26, 2024
@lanedirt
Refactor 2fa methods from AuthController to its own controller (#70)
a9e41fa
@lanedirt lanedirt linked a pull request Aug 26, 2024 that will close this issue
Add TOTP authenticator support to client #182
Merged
lanedirt added a commit that referenced this issue Aug 26, 2024
@lanedirt
Update Login.razor (#70)
e06f266
lanedirt added a commit that referenced this issue Aug 26, 2024
@lanedirt
Code style refactor (#70)
ec927ae
lanedirt added a commit that referenced this issue Aug 26, 2024
@lanedirt
Update JSON models to have required properties (#70)
7812d87
lanedirt added a commit that referenced this issue Aug 26, 2024
@lanedirt
Update Security.razor (#70)
6a493c4
lanedirt added a commit that referenced this issue Aug 26, 2024
@lanedirt
Update Security.razor (#70)
6f67f8f
lanedirt added a commit that referenced this issue Aug 26, 2024
@lanedirt
Update Security.razor (#70)
7d6a5fa 
Update Login.razor (#70)
Code style refactor (#70)
Update JSON models to have required properties (#70)
@github-project-automation github-project-automation bot moved this from In progress to Done in AliasVault Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
AliasVault
Status: Done
Milestone
Usability / UX polishing
Development

Successfully merging a pull request may close this issue.

Add TOTP authenticator support to client lanedirt/AliasVault
1 participant
@lanedirt