Skip to content

Commit

Permalink
Merge branch 'main' into dependabot/npm_and_yarn/vite-5.2.8
Browse files Browse the repository at this point in the history
  • Loading branch information
pirog authored Apr 5, 2024
2 parents 5af3a18 + e38738c commit 016767d
Show file tree
Hide file tree
Showing 7 changed files with 39 additions and 7 deletions.
19 changes: 19 additions & 0 deletions .github/workflows/label-add-to-project.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Add to Contrib Project

on:
issues:
types: [labeled]
pull_request:
types: [labeled]

jobs:
add_to_project:
runs-on: ubuntu-latest
steps:
- name: Add issue/PR to GitHub Project
if: github.event.label.name == 'flag'
uses: actions/add-to-project@v1.0.0
with:
project-url: https://github.com/orgs/lando/projects/7
github-token: ${{ secrets.SHADOW_COUNCIL_ESCALATOR }}
labeled: flag
3 changes: 2 additions & 1 deletion builders/php.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ module.exports = {
_php: '/usr/local/etc/php/conf.d/xxx-lando-default.ini',
vhosts: '/etc/apache2/sites-enabled/000-default.conf',
php: '/usr/local/etc/php/conf.d/zzz-lando-my-custom.ini',
pool: '/usr/local/etc/php-fpm.d/zz-lando.conf',
},
sources: [],
suffix: '4',
Expand All @@ -140,7 +141,7 @@ module.exports = {
options = parseConfig(_.merge({}, config, options));
// Mount our default php config
options.volumes.push(`${options.confDest}/${options.defaultFiles._php}:${options.remoteFiles._php}`);

options.volumes.push(`${options.confDest}/${options.defaultFiles.pool}:${options.remoteFiles.pool}`);
// Shift on the docker entrypoint if this is a more recent version
if (options.version !== 'custom' && semver.gt(semver.coerce(options.version), '5.5.0')) {
options.command.unshift('docker-php-entrypoint');
Expand Down
3 changes: 2 additions & 1 deletion examples/custom/.lando.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ services:
webroot: web
config:
php: config/php.ini
pool: config/www.conf
composer_version: '2.1.14'
overrides:
image: devwithlando/php:8.1-fpm-4
Expand All @@ -31,4 +32,4 @@ tooling:
# This is important because it lets lando know to test against the plugin in this repo
# DO NOT REMOVE THIS!
plugins:
"@lando/php": ./../../
"@lando/php": ./../../
3 changes: 3 additions & 0 deletions examples/custom/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ lando ssh -s custom81_nginx -c "curl https://localhost" | grep "WEBDIR"
# Should use custom php ini if specified
lando ssh -s custom81 -c "php -i | grep memory_limit | grep 514"
lando ssh -s custom81 -c "curl http://custom81_nginx" | grep html_errors | grep On | grep On

# Detect whether php-fpm is using custom www.conf
lando ssh -s custom81 -c "php -i | grep start_servers | grep 2"
```

Destroy tests
Expand Down
8 changes: 8 additions & 0 deletions examples/custom/config/www.conf
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
; Override default PHP-FPM settings.
[www]

pm.max_children = 5
pm.start_servers = 2
pm.min_spare_servers = 1
pm.max_spare_servers = 3
pm.max_requests = 500
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"devDependencies": {
"@babel/eslint-parser": "^7.16.0",
"@lando/leia": "0.6.5",
"@lando/vitepress-theme-default-plus": "^1.0.0-beta.42",
"@lando/vitepress-theme-default-plus": "^1.0.1",
"chai": "^4.3.4",
"command-line-test": "^1.0.10",
"eslint": "^7.32.0",
Expand Down

0 comments on commit 016767d

Please sign in to comment.