Add non-generic versions of service registration methods #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good - could you please include the XML comments above these new methods, so that intellisense picks them up properly? Thanks for the contribution! |
dougrday
reviewed
Oct 25, 2018
dougrday
reviewed
Oct 25, 2018
|
👍 Done! |
dougrday
approved these changes
Nov 1, 2018
|
This was released in 0.4.2-beta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring in an automatic fashion (scanning an assembly for
IQueryBuilderimplementations and adding each one), using the generic methods is not really convenient.This PR adds registration methods which accept straight forward
Typearguments, which I believe is a common convention in other libraries.I am happy to add documentation for the new methods if this PR seems ok in other aspects.