Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate ArrayInput default value to an empty array #107

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Apr 3, 2024

Reinstates removed method and property in ArrayInput and also deprecates them so that the default value for an ArrayInput is an empty array, maintaining BC with the 2.x series

Fixes #106

Reinstates removed method and property in `ArrayInput` and also deprecates them so that the default value for an ArrayInput is an empty array, maintaining BC with the 2.x series

Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel added the Bug Something isn't working label Apr 3, 2024
@gsteel gsteel added this to the 2.30.1 milestone Apr 3, 2024
@gsteel gsteel requested a review from Ocramius April 3, 2024 15:09
@Ocramius Ocramius self-assigned this Apr 3, 2024
@Ocramius
Copy link
Member

Ocramius commented Apr 3, 2024

Thanks @gsteel and @kersysgediminas

@Ocramius Ocramius merged commit f07a908 into laminas:2.30.x Apr 3, 2024
11 checks passed
@Ocramius Ocramius deleted the array-input-bc-break branch April 3, 2024 15:14
@Ocramius
Copy link
Member

Ocramius commented Apr 3, 2024

@gsteel CI failed to merge-up 2.30.x to 2.31.x here - can you open a PR?

Ref: https://github.com/laminas/laminas-inputfilter/actions/runs/8541206209/job/23399995864

@gsteel
Copy link
Member Author

gsteel commented Apr 3, 2024

Done! #109 Thanks @Ocramius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants