Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Psalm integration #25

Merged
merged 3 commits into from
Jul 11, 2023
Merged

feat: add Psalm integration #25

merged 3 commits into from
Jul 11, 2023

Conversation

superrosko
Copy link
Contributor

Q A
QA yes

Description

  • Create a psalm.xml.dist in the project root
  • Copy and paste the contents from this psalm.xml.dist and fix projectFiles
  • Run $ composer --dev require vimeo/psalm
  • Run $ composer require --dev psalm/plugin-phpunit
  • Run $ vendor/bin/psalm --config=psalm.xml.dist --set-baseline=psalm-baseline.xml
  • Add a composer script static-analysis with the command psalm --shepherd --stats
  • Remove phpstan from the project (phpstan.neon.dist, .travis.yml entry, composer.json require-dev and scripts)

Closes #13

@superrosko superrosko force-pushed the feature/psalm-integration branch from 311c79c to 121b17f Compare October 2, 2021 14:47
@Ocramius Ocramius added this to the 1.8.0 milestone Jun 3, 2022
@Ocramius Ocramius changed the base branch from 1.7.x to 1.8.x June 3, 2022 10:45
@weierophinney weierophinney force-pushed the feature/psalm-integration branch from 121b17f to 9a0a68a Compare July 11, 2023 16:26
superrosko and others added 2 commits July 11, 2023 11:39
@superrosko @weierophinney
feat: add Psalm integration
2f4551b 
Signed-off-by: Dmitriy Bespalov <dbespalov.rosko@gmail.com>
@weierophinney
qa: create baseline
8360be4 
Resolved errors that could reasonably resolved without major refactoring; pushed remainer to basline.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney weierophinney force-pushed the feature/psalm-integration branch from 9a0a68a to 8360be4 Compare July 11, 2023 16:49
@weierophinney
qa: no need to initialize to null for nullable properties
67b79d4 
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
weierophinney approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@weierophinney weierophinney merged commit 3cc7840 into laminas-api-tools:1.8.x Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weierophinney weierophinney weierophinney approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Psalm integration
3 participants
@superrosko @weierophinney @Ocramius