-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(l2): make deposits for the rich accounts #2095
Open
tomip01
wants to merge
32
commits into
main
Choose a base branch
from
l2/deposit-rich-accounts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view
|
* Now fetching from block 0 * deposits are working
* it implies that no hardcoding of the starting block of the watcher * use last block observed from the contract
d936aa4
to
29f9a04
Compare
The |
Nice catch!, changed here 9ee11bc |
jrchatruc
reviewed
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In this PR we change the behavior of the deployer. We make deposits from the rich accounts to the L1 in the L2 common bridge to make the rich accounts of the L2.
Description
make_deposits()
function in thedeployer.rs
. Here we iterate from the Private Keys of the L1, calculate their addresses and make a depositprivate_keys_l1
docker-compose-l2.yaml
for the files of the private keys and genesis to be able to read themgenesis-l2.json
Closes #2017