-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement hint from get_felt_bitlength
(Garaga)
#993
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpcenteno
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
April 14, 2023 21:41
Oppen
approved these changes
Apr 14, 2023
Can you add some unit tests? |
jpcenteno
force-pushed
the
get_felt_bitlength-garaga
branch
from
April 17, 2023 18:35
1049107
to
6c0e700
Compare
Benchmark Results for unmodified programs 🚀
|
Codecov Report
@@ Coverage Diff @@
## main #993 +/- ##
=======================================
Coverage 98.04% 98.04%
=======================================
Files 76 77 +1
Lines 31880 31927 +47
=======================================
+ Hits 31256 31303 +47
Misses 624 624
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
reviewed
Apr 18, 2023
pefontana
approved these changes
Apr 18, 2023
Done |
Oppen
approved these changes
Apr 19, 2023
Oppen
approved these changes
Apr 19, 2023
jpcenteno
force-pushed
the
get_felt_bitlength-garaga
branch
from
April 19, 2023 21:37
10f6e27
to
e8f0984
Compare
Oppen
approved these changes
Apr 19, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Apr 19, 2023
pefontana
added
the
whitelisted-hint
Implementation of hint on whitelist directory
label
Apr 20, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Implement hint from `get_felt_bitlength` (Garaga) * Update changelog * Fix format * Use WASM-compatible `HashMap` * Fix broken imports * Import WASM-compatible `String` * Add a unit test for bit lenght hint * Fix typo * Add test cases * Refactor tests * Add a wraparound test * Fix missing import for wasm-tests * Remove unused match clause. --------- Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement hint from get_felt_bitlength (Garaga)
ISSUE: #977
Description
Implement hint on
get_felt_bitlength
#993BuiltinHintProcessor
now supports the following hint:Used by the
Garaga
library functionget_felt_bitlength
Checklist