feat: Implement hint on uint256_mul_div_mod
#957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #957 +/- ##
========================================
Coverage 97.74% 97.75%
========================================
Files 74 74
Lines 30392 30538 +146
========================================
+ Hits 29708 29851 +143
- Misses 684 687 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fmoletta
changed the title
uint256_mul_div_mod
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
fmoletta
added
the
whitelisted-hint
This was referenced Apr 13, 2023
fmoletta
changed the title
uint256_mul_div_moduint256_mul_div_mod
Oppen
reviewed
Apr 13, 2023
Comment on lines
+242
to
+256
| let a_addr = get_relocatable_from_var_name("a", vm, ids_data, ap_tracking)?; | ||
| let b_addr = get_relocatable_from_var_name("b", vm, ids_data, ap_tracking)?; | ||
| let div_addr = get_relocatable_from_var_name("div", vm, ids_data, ap_tracking)?; | ||
| let quotient_low_addr = | ||
| get_relocatable_from_var_name("quotient_low", vm, ids_data, ap_tracking)?; | ||
| let quotient_high_addr = | ||
| get_relocatable_from_var_name("quotient_high", vm, ids_data, ap_tracking)?; | ||
| let remainder_addr = get_relocatable_from_var_name("remainder", vm, ids_data, ap_tracking)?; | ||
|
|
||
| let a_low = vm.get_integer(a_addr)?; | ||
| let a_high = vm.get_integer((a_addr + 1_usize)?)?; | ||
| let b_low = vm.get_integer(b_addr)?; | ||
| let b_high = vm.get_integer((b_addr + 1_usize)?)?; | ||
| let div_low = vm.get_integer(div_addr)?; | ||
| let div_high = vm.get_integer((div_addr + 1_usize)?)?; |
There was a problem hiding this comment.
I think we'll need a getter for this kind of structured data eventually, if possible generic so they're still refs.
Oppen
approved these changes
Apr 13, 2023
pefontana
approved these changes
Apr 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Add normalize address hints * Revert "Add normalize address hints" This reverts commit 86077f2. * Add uint256_mul_div_mod hint * Add hint to match * Expand uint256 integration test * use u128::MAX * Fix value * Manage quotient & remainder as BigUint * Add test for hint * Add test for hint * Add misc test * Add changelog entry * fmt * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements hint: https://github.com/starkware-libs/cairo-lang/blob/55a26f4228dcff9c51d3d6bfd5e6638bafe63101/src/starkware/cairo/common/uint256.cairo#L242
unit tests
integration tests