-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Memory
into MemorySegmentManager
#830
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
changed the title
Move Memory into MemorySegmentManager
Move Feb 13, 2023
Memory
into MemorySegmentManager
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
HermanObst,
juanbono,
Jrigada,
pefontana and
Juan-M-V
as code owners
February 13, 2023 14:48
Codecov Report
@@ Coverage Diff @@
## main #830 +/- ##
==========================================
- Coverage 97.12% 97.11% -0.02%
==========================================
Files 69 69
Lines 28770 28609 -161
==========================================
- Hits 27944 27783 -161
Misses 826 826
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jrigada
approved these changes
Feb 13, 2023
Oppen
reviewed
Feb 13, 2023
…thods to keep the api similar
Oppen
approved these changes
Feb 13, 2023
Oppen
approved these changes
Feb 13, 2023
Oppen
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to reduce the complexity of the VM's memory. and also enforce proper usage (as the memory and its segment manager are now a "unified" entity)
memory
field fromVirtualMachine
memory
field toMemorySegmentManager
Memory
argument from methods whereMemorySegmentManager
is also an argumentsegments
(an extension of thememory
macro