Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't validate memory values #1783

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Don't validate memory values #1783

merged 1 commit into from
Jun 19, 2024

Conversation

Alon-Ti
Copy link
Contributor

@Alon-Ti Alon-Ti commented Jun 4, 2024

Remove validation of values in CairoPie Memory.

@Alon-Ti Alon-Ti force-pushed the dont-validate-addresses branch from cb38b3c to fb435b1 Compare June 4, 2024 18:36
juanbono
juanbono requested changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests to this?

@Alon-Ti
Copy link
Contributor Author

Alon-Ti commented Jun 6, 2024

@juanbono, I want to add a pathological CairoPie end to end test that will cover this and the previous issue against python VM output (see slack), I can do that once #1781 is merged.

@Alon-Ti Alon-Ti force-pushed the dont-validate-addresses branch from fb435b1 to 62ed419 Compare June 9, 2024 15:06
@Alon-Ti
Copy link
Contributor Author

Alon-Ti commented Jun 9, 2024

@juanbono I amended an existing test to cover this, will add a test CairoPie with all the edge cases once I'm sure all our test CairoPies run.

@Alon-Ti Alon-Ti force-pushed the dont-validate-addresses branch from 62ed419 to 94df9f9 Compare June 15, 2024 14:41
@Alon-Ti Alon-Ti force-pushed the dont-validate-addresses branch from 94df9f9 to b600ba3 Compare June 15, 2024 14:45
@fmoletta fmoletta added this pull request to the merge queue Jun 19, 2024
Merged via the queue into lambdaclass:main with commit 8b5d1c6 Jun 19, 2024
67 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oppen Oppen Oppen approved these changes

@juanbono juanbono juanbono approved these changes

@fmoletta fmoletta fmoletta approved these changes

@igaray igaray Awaiting requested review from igaray igaray is a code owner

@pefontana pefontana Awaiting requested review from pefontana pefontana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alon-Ti @Oppen @juanbono @fmoletta