fix: make MemorySegmentManager.finalize() public #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is used in some of the bootloader hints.
odesenfans
requested review from
igaray,
Oppen,
fmoletta,
juanbono and
pefontana
as code owners
odesenfans
changed the title
fmoletta
approved these changes
May 23, 2024
juanbono
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: this method is used in some of the bootloader hints, see here.
We are currently taking out the bootloader hints out of our fork of
cairo-vmso we need this method to be public. This is among the last changes required to get this done and use upstreamcairo-vm(probably one more change related to the initial value ofexec_scopesbut that's it).Alternative solutions:
finalize()public, maybe with a disclaimer explaining why it's public to avoid mistakes.Checklist