Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle off2 immediate case in get_integer_from_reference #1701

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Apr 5, 2024

Closes #1689

@fmoletta fmoletta marked this pull request as ready for review April 5, 2024 21:13
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 96.56%. Comparing base (c692b75) to head (935ef36).

Files Patch % Lines
...int_processor/builtin_hint_processor/math_utils.rs 90.47% 2 Missing ⚠️
.../hint_processor/builtin_hint_processor/ec_utils.rs 66.66% 1 Missing ⚠️
...cessor/builtin_hint_processor/find_element_hint.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1701   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files          96       96           
  Lines       38494    38488    -6     
=======================================
- Hits        37170    37166    -4     
+ Misses       1324     1322    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 5, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.282 ± 0.027 2.252 2.353 1.01 ± 0.02
head big_factorial 2.262 ± 0.029 2.229 2.307 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.261 ± 0.010 2.250 2.276 1.00
head big_fibonacci 2.307 ± 0.105 2.244 2.592 1.02 ± 0.05
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.402 ± 0.159 8.257 8.602 1.00
head blake2s_integration_benchmark 8.511 ± 0.274 8.353 9.244 1.01 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.306 ± 0.005 2.297 2.312 1.00
head compare_arrays_200000 2.329 ± 0.062 2.280 2.499 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.429 ± 0.013 1.420 1.466 1.01 ± 0.02
head dict_integration_benchmark 1.414 ± 0.028 1.393 1.482 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.297 ± 0.009 1.281 1.308 1.00
head field_arithmetic_get_square_benchmark 1.298 ± 0.007 1.290 1.307 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.373 ± 0.142 8.264 8.593 1.00
head integration_builtins 8.423 ± 0.083 8.346 8.571 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.705 ± 0.154 8.528 8.857 1.00
head keccak_integration_benchmark 8.708 ± 0.120 8.592 8.873 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.320 ± 0.016 2.301 2.352 1.00
head linear_search 2.328 ± 0.021 2.307 2.368 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.549 ± 0.008 1.541 1.561 1.00
head math_cmp_and_pow_integration_benchmark 1.555 ± 0.015 1.541 1.583 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.421 ± 0.010 1.410 1.437 1.00
head math_integration_benchmark 1.445 ± 0.023 1.416 1.487 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.262 ± 0.029 1.243 1.340 1.00
head memory_integration_benchmark 1.279 ± 0.032 1.246 1.348 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.603 ± 0.023 1.592 1.662 1.00
head operations_with_data_structures_benchmarks 1.604 ± 0.012 1.592 1.627 1.00 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 592.0 ± 0.9 590.5 593.1 1.00 ± 0.01
head pedersen 590.3 ± 2.9 587.0 595.6 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 980.2 ± 20.6 970.3 1038.3 1.00
head poseidon_integration_benchmark 980.8 ± 1.6 978.5 983.4 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.862 ± 0.027 1.842 1.933 1.00
head secp_integration_benchmark 1.872 ± 0.012 1.859 1.903 1.01 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 694.5 ± 1.7 691.9 697.0 1.00
head set_integration_benchmark 743.4 ± 3.7 737.0 747.3 1.07 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.600 ± 0.069 4.533 4.722 1.00
head uint256_integration_benchmark 4.650 ± 0.016 4.623 4.679 1.01 ± 0.02

@pefontana pefontana added this pull request to the merge queue Apr 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 8, 2024
@fmoletta fmoletta added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 404407d Apr 8, 2024
51 of 52 checks passed
@fmoletta fmoletta deleted the fix-get-integer branch April 8, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle fn get_integer_from_reference when offset2 is an immediate
3 participants