dev: bump cairo 1 compiler dep to 2.4 #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greged93
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono and
pefontana
as code owners
fmoletta
previously approved these changes
Jan 3, 2024
|
Looking forward to this feature!! |
greged93
force-pushed
the
dev/bump-compiler
branch
from
1daf372 to
ea1e8c9
Compare
|
I'm not sure why the CI keeps failing, if you have an idea I can look into it? |
|
OK, I think I found the issue. The |
|
Try with this: diff --git a/cairo1-run/Makefile b/cairo1-run/Makefile
index 337cf3a53..8c39b51ae 100644
--- a/cairo1-run/Makefile
+++ b/cairo1-run/Makefile
@@ -15,7 +15,7 @@ MEMORY:=$(patsubst $(CAIRO_1_FOLDER)/%.cairo, $(CAIRO_1_FOLDER)/%.memory, $(CAIR
deps:
git clone https://github.com/starkware-libs/cairo.git \
&& cd cairo \
- && git checkout v2.3.1 \
+ && git checkout v2.4.3 \
&& cd .. \
&& mv cairo/corelib/ . \
&& rm -rf cairo/ |
|
Ahhhh missed this! Thanks @Oppen ! |
|
@greged93 most tests already pass, but there seems to be something broken with |
|
Yes found the issue, will update |
|
works for me now locally @Oppen |
|
Let's ping @pefontana and @fmoletta for their reviews :) |
fmoletta
approved these changes
Jan 11, 2024
pefontana
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump cairo compiler
Description
Bumps the dependency of the cairo 1 compiler to 2.4.
Checklist