-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow running instructions from pc
s outside the program segment
#1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1493 +/- ##
==========================================
- Coverage 96.81% 96.81% -0.01%
==========================================
Files 96 96
Lines 39581 39684 +103
==========================================
+ Hits 38322 38419 +97
- Misses 1259 1265 +6 ☔ View full report in Codecov by Sentry. |
Benchmark Results for unmodified programs 🚀
|
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
juanbono and
pefontana
as code owners
November 24, 2023 14:38
Oppen
approved these changes
Nov 24, 2023
Oppen
approved these changes
Nov 24, 2023
pefontana
approved these changes
Nov 27, 2023
…s/cairo-vm into run-instruction-from-other-pc
Oppen
changed the title
Allow running instructions from
Allow running instructions from Nov 28, 2023
pc
s outside the program segementpc
s outside the program segment
Oppen
approved these changes
Nov 28, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to run the os, we need to load programs into new segments and run them by setting the pc to their starting location. In order to achieve this, we must handle pc's with an index different from 0 in
step_instruction
.Depends on #1492 (for testing)