-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CairoPie
serialization.
#1444
Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
ee56400
Fix serialization.
azteca1998 2dc8e18
Remove `#[derive(Deserialize)]` from `CairoPie` and family.
azteca1998 80976c9
Add note.
azteca1998 df6dca5
Merge branch 'main' into fix-cairo-pie-serialization
azteca1998 6b37835
Fix `CairoPie` serialization test.
azteca1998 cbe51e0
Update `CHANGELOG.md`.
azteca1998 5a1b3eb
Fix test.
azteca1998 5ecbf6b
Fix WebAssembly target.
azteca1998 622d73c
Add `prime` field to the program.
azteca1998 a711c00
Fix test.
azteca1998 cd1b114
Fix `no_std`.
azteca1998 6bed056
Skip `CairoPie` memory serialization and update reference JSON.
azteca1998 c4ff3fb
Fix test
azteca1998 d0ba7c7
Fix stuff.
azteca1998 cb43675
Add `version` field.
azteca1998 dd7e561
Add memory serialization.
azteca1998 0adc0d8
Fix WebAssembly and `no_std`.
azteca1998 b46efd0
Fix comments.
azteca1998 04ea28c
Fix comment.
azteca1998 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add
version
field.
- Loading branch information
commit cb436751a3c63dec336bbb99b466b2eac5112341
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,5 +55,8 @@ | |
"size": 10, | ||
"index": 0 | ||
} | ||
}, | ||
"version": { | ||
"cairo_pie": "1.1" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it is possible, but can we use a String type for the version field.
Plus add a constant with the CairoPieVersion String, so it is easy to change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it is possible, it'd need to be initialized every time the CairoPie object is created. Having it as it is now this cannot happen because the version field is zero-sized.
The constant is easy. Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice