-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename cairo-rs to cairo-vm #1289
Conversation
docs/hint_processor/hint_design.md
Outdated
@@ -67,11 +67,11 @@ Notes | |||
Notes | |||
- Learn to use wasm tooling | |||
- Learn how to compile python to wasm | |||
- Definir the interfaces between the embedded wasm vm and cairo-rs | |||
- Definir the interfaces between the embedded wasm vm and cairo-vm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jeje
done
README.md
Outdated
|
||
A faster and safer implementation of the Cairo VM in Rust | ||
|
||
[Report Bug](https://github.com/lambdaclass/cairo-rs/issues/new?labels=bug&title=bug%3A+) · [Request Feature](https://github.com/lambdaclass/cairo-rs/issues/new?labels=enhancement&title=feat%3A+) | ||
[Report Bug](https://github.com/lambdaclass/cairo-vm/issues/new?labels=bug&title=bug%3A+) · [Request Feature](https://github.com/lambdaclass/cairo-vm/issues/new?labels=enhancement&title=feat%3A+) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change this link to use the bug issue template:
https://github.com/lambdaclass/cairo-vm/issues/new?assignees=&labels=bug&projects=&template=bug_report.md&title=bug%3A+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good!
done
Codecov Report
@@ Coverage Diff @@
## main #1289 +/- ##
==========================================
+ Coverage 97.57% 97.90% +0.32%
==========================================
Files 92 89 -3
Lines 37475 35471 -2004
==========================================
- Hits 36566 34727 -1839
+ Misses 909 744 -165
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark Results for unmodified programs 🚀
|
Should we mention this change in the changelog? |
Maybe. Since some users point to specific revisions, this is probably true. In general, tho, you'd refer to the crate on crates.io, which has always been |
I can add it :why-not |
* Rename cairo-rs to cairo-vm * Rename cairo-rs-py to cairo-vm * corrections * Add line to changelog * typo
* Rename cairo-rs to cairo-vm * Rename cairo-rs-py to cairo-vm * corrections * Add line to changelog * typo
* Rename cairo-rs to cairo-vm * Rename cairo-rs-py to cairo-vm * corrections * Add line to changelog * typo
* Rename cairo-rs to cairo-vm * Rename cairo-rs-py to cairo-vm * corrections * Add line to changelog * typo
Rename cairo-rs to cairo-vm
Checklist