feat: Add feature lambdaworks-felt to felt & cairo-vm crates

.github/workflows/bench.yml

@@ -14,11 +14,9 @@ jobs:
   build:
     runs-on: ubuntu-20.04
     steps:
-    - name: Install Rust 1.66.1 
-      uses: actions-rs/toolchain@v1
+    - name: Install Rust
+      uses: dtolnay/rust-toolchain@1.69.0
       with:
-          toolchain: 1.66.1 
-          override: true
           components: rustfmt, clippy
     - uses: actions/checkout@v3
     - name: Python3 Build

.github/workflows/hint_accountant.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
     - name: Install Rust toolchain
-      uses: dtolnay/rust-toolchain@1.66.1
+      uses: dtolnay/rust-toolchain@1.69.0
     - name: Set up Cargo cache
       uses: Swatinem/rust-cache@v2
     - name: Checkout

.github/workflows/hyperfine.yml

@@ -74,9 +74,7 @@ jobs:
 
       - name: Install Rust
         if: ${{ steps.cache.outputs.cache-hit != 'true' }}
-        uses: dtolnay/rust-toolchain@stable
-        with:
-          toolchain: 1.66.1
+        uses: dtolnay/rust-toolchain@1.69.0
 
       - name: Checkout
         if: ${{ steps.cache.outputs.cache-hit != 'true' }}

.github/workflows/iai_main.yml

@@ -9,11 +9,7 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
     - name: Install Rust
-      uses: actions-rs/toolchain@v1
-      with:
-          toolchain: 1.66.1
-          override: true
-          profile: minimal
+      uses: dtolnay/rust-toolchain@1.69.0
     - name: Python3 Build
       uses: actions/setup-python@v4
       with:

.github/workflows/iai_pr.yml

@@ -9,11 +9,7 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
     - name: Install Rust
-      uses: actions-rs/toolchain@v1
-      with:
-          toolchain: 1.66.1
-          override: true
-          profile: minimal
+      uses: dtolnay/rust-toolchain@1.69.0
     - name: Python3 Build
       uses: actions/setup-python@v4
       with:
@@ -46,11 +42,7 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
     - name: Install Rust
-      uses: actions-rs/toolchain@v1
-      with:
-          toolchain: 1.66.1
-          override: true
-          profile: minimal
+      uses: dtolnay/rust-toolchain@1.69.0
     - name: Python3 Build
       uses: actions/setup-python@v4
       with:

.github/workflows/publish.yml

@@ -13,11 +13,7 @@ jobs:
     - name: Checkout sources
       uses: actions/checkout@v2
     - name: Install stable toolchain
-      uses: actions-rs/toolchain@v1
-      with:
-        profile: minimal
-        toolchain: stable
-        override: true
+      uses: dtolnay/rust-toolchain@1.69.0
     - name: Publish crate cairo-take_until_unbalanced
       env:
           CRATES_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}
@@ -34,4 +30,3 @@ jobs:
       env:
           CRATES_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}
       run: cargo publish --token ${CRATES_TOKEN} --all-features -p cairo-vm
-

.github/workflows/rust.yml

@@ -170,7 +170,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        target: [ test, test-no_std, test-wasm ]
+        target: [ test, test-no_std, test-wasm, test-lambdaworks-felt ]
         # TODO: features
     name: Run tests
     runs-on: ubuntu-22.04
@@ -230,6 +230,9 @@ jobs:
           # NOTE: release mode is needed to avoid "too many locals" error
           wasm-pack test --release --node vm --no-default-features
           ;;
+        'test-lambdaworks-felt')
+          cargo llvm-cov nextest --lcov --output-path lcov-${{ matrix.target }}.info --workspace --features "cairo-1-hints, test_utils, lambdaworks-felt"
+          ;;
         esac
 
     - name: Save coverage

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 #### Upcoming Changes
 
+* feat: Add feature `lambdaworks-felt` to `felt` crate [#1218](https://github.com/lambdaclass/cairo-rs/pull/1281)
+
+    Changes under this feature:
+  * `Felt252` now uses _lambdaworks_' `FieldElement` internally
+  * BREAKING: some methods of `Felt252` were removed, namely: `modpow` and `to_bytes_be`
+
 * BREAKING: Integrate `RunResources` logic into `HintProcessor` trait [#1274](https://github.com/lambdaclass/cairo-rs/pull/1274)
   * Rename trait `HintProcessor` to `HintProcessorLogic`
   * Add trait `ResourceTracker`

felt/Cargo.toml

@@ -9,6 +9,7 @@ description = "Field elements representation for the Cairo VM"
 default = ["std"]
 std = []
 alloc = []
+lambdaworks-felt = ["dep:lambdaworks-math"]
 
 [dependencies]
 num-integer = { version = "0.1.45", default-features = false }
@@ -18,6 +19,7 @@ lazy_static = { version = "1.4.0", default-features = false, features = [
     "spin_no_std",
 ] }
 serde = { version = "1.0", features = ["derive"], default-features = false }
+lambdaworks-math = { git = "https://github.com/lambdaclass/lambdaworks", rev = "5d61e79", default-features = false, optional=true }
 
 [dev-dependencies]
 proptest = "1.1.0"

felt/src/arbitrary_lambdaworks.rs

@@ -0,0 +1,47 @@
+use lambdaworks_math::{field::element::FieldElement, unsigned_integer::element::UnsignedInteger};
+use num_traits::Zero;
+use proptest::prelude::*;
+
+use crate::{Felt252, FIELD_HIGH, FIELD_LOW};
+
+/// Returns a [`Strategy`] that generates any valid Felt252
+fn any_felt252() -> impl Strategy<Value = Felt252> {
+    (0..=FIELD_HIGH)
+        // turn range into `impl Strategy`
+        .prop_map(|x| x)
+        // choose second 128-bit limb capped by first one
+        .prop_flat_map(|high| {
+            let low = if high == FIELD_HIGH {
+                (0..FIELD_LOW).prop_map(|x| x).sboxed()
+            } else {
+                any::<u128>().sboxed()
+            };
+            (Just(high), low)
+        })
+        // turn (u128, u128) into limbs array and then into Felt252
+        .prop_map(|(high, low)| {
+            let limbs = [
+                (high >> 64) as u64,
+                (high & ((1 << 64) - 1)) as u64,
+                (low >> 64) as u64,
+                (low & ((1 << 64) - 1)) as u64,
+            ];
+            FieldElement::new(UnsignedInteger::from_limbs(limbs))
+        })
+        .prop_map(|value| Felt252 { value })
+}
+
+/// Returns a [`Strategy`] that generates any nonzero Felt252
+pub fn nonzero_felt252() -> impl Strategy<Value = Felt252> {
+    any_felt252().prop_filter("is zero", |x| !x.is_zero())
+}
+
+impl Arbitrary for Felt252 {
+    type Parameters = ();
+
+    fn arbitrary_with(_args: Self::Parameters) -> Self::Strategy {
+        any_felt252().sboxed()
+    }
+
+    type Strategy = SBoxedStrategy<Self>;
+}

felt/src/bigint_felt.rs

@@ -12,7 +12,7 @@ use core::{
     },
 };
 
-use crate::{FeltOps, ParseFeltError};
+use crate::{lib_bigint_felt::FeltOps, ParseFeltError};
 
 pub const FIELD_HIGH: u128 = (1 << 123) + (17 << 64); // this is equal to 10633823966279327296825105735305134080
 pub const FIELD_LOW: u128 = 1;
@@ -840,12 +840,6 @@ impl<const PH: u128, const PL: u128> fmt::Debug for FeltBigInt<PH, PL> {
     }
 }
 
-impl fmt::Display for ParseFeltError {
-    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
-        write!(f, "{ParseFeltError:?}")
-    }
-}
-
 #[cfg(test)]
 mod tests {
     use super::*;