-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use our own is_prime impl #1238
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1238 +/- ##
========================================
Coverage 97.61% 97.62%
========================================
Files 88 89 +1
Lines 36112 37001 +889
========================================
+ Hits 35251 36122 +871
- Misses 861 879 +18
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help! 😄
By the way, do you have a way to check if this new way of checking for prime numbers does not hurt performances? |
Yes! We have benchmarks that run as part of the CI. The numbers usually appear as a comment on the PR, but in this case, it fails because of permissions. You can see the raw output in the logs. |
@MegaRedHand
|
custom is_prime
Description
num-prime
cannot be used in ano_std
env.This PR replace the calls to
num_prime::is_prime
with our custom implIt incidentally restore
no_std
support forcairo-vm