-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add method CairoRunner::initialize_function_runner_cairo1
#1151
Conversation
CairoRunner::run_from_entrypoint_with_builtins
Benchmark Results for unmodified programs 🚀
|
CairoRunner::run_from_entrypoint_with_builtins
CairoRunner::initialize_function_runner_cairo1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I only have a non-blocking question about a comment.
To save you time: the error in the tests for wasm boils down to the global prelude of Rust not being there. The new helpers and macro need to use |
Codecov Report
@@ Coverage Diff @@
## main #1151 +/- ##
=======================================
Coverage 97.07% 97.07%
=======================================
Files 88 88
Lines 35545 35583 +38
=======================================
+ Hits 34506 34543 +37
- Misses 1039 1040 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…mbdaclass#1151) * Move builtins field outside of shared_program_data * Add method CairoRunner::run_from_entrypoint_with_builtins * Add changelog entry * Revert change * Add `CairoRunner::initialize_function_runner_cairo1` * Use initialize_function_runner_cairo1 * Update changelog * Add feature flag * Clippy * Add missing import * Fix std path * Add path for Vec in program macro * Add segment_arena to BuiltinName enum * Add change to changelog * Fix test func * Add String & Vec imports for alloc feature * Remove irrelevant information from doc comment * Add path for String * Fix import * Fix test * Fix test * Fix test * Fix typo in changelog * Fix duplicate entry title in changelog
This PR aims to solve the issue of
CasmContractClass
having the builtins stored by entrypoint instead of a universal builtin field.In order to fix this, the method
CairoRunner::initialize_function_runner_cairo1
was added which allows setting the program builtinsChecklist