Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CairoRunner.get_program #1123

Merged
merged 2 commits into from
May 5, 2023
Merged

Add CairoRunner.get_program #1123

merged 2 commits into from
May 5, 2023

Conversation

pefontana
Copy link
Collaborator

@pefontana pefontana commented May 5, 2023

Add CairoRunner.get_program

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@pefontana pefontana marked this pull request as ready for review May 5, 2023 15:21
Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sir

@Oppen Oppen enabled auto-merge May 5, 2023 15:29
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #1123 (5dc6075) into main (913aa49) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files          85       85           
  Lines       34533    34546   +13     
=======================================
+ Hits        33896    33909   +13     
  Misses        637      637           
Impacted Files Coverage Δ
src/vm/runners/cairo_runner.rs 98.14% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Oppen Oppen added this pull request to the merge queue May 5, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 16.671 ± 0.072 16.581 16.792 1.00
head blake2s_integration_benchmark 16.718 ± 0.143 16.619 17.108 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 5.077 ± 0.038 5.042 5.153 1.00
head compare_arrays_200000 5.079 ± 0.063 5.033 5.248 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 3.190 ± 0.018 3.166 3.216 1.00
head dict_integration_benchmark 3.195 ± 0.035 3.167 3.288 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 5.394 ± 0.055 5.354 5.516 1.00 ± 0.01
head factorial_multirun 5.370 ± 0.013 5.353 5.394 1.00
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 4.783 ± 0.047 4.738 4.860 1.00 ± 0.01
head fibonacci_1000_multirun 4.760 ± 0.045 4.723 4.873 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base field_arithmetic_get_square_benchmark 201.6 ± 0.7 200.3 202.7 1.00
head field_arithmetic_get_square_benchmark 201.8 ± 0.7 201.1 203.4 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 15.669 ± 0.100 15.574 15.862 1.00 ± 0.01
head integration_builtins 15.621 ± 0.040 15.560 15.674 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 16.771 ± 0.149 16.676 17.169 1.00
head keccak_integration_benchmark 16.800 ± 0.138 16.663 17.146 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 5.124 ± 0.061 5.074 5.254 1.00 ± 0.02
head linear_search 5.113 ± 0.056 5.068 5.266 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.466 ± 0.008 3.453 3.479 1.00
head math_cmp_and_pow_integration_benchmark 3.467 ± 0.017 3.449 3.504 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 3.241 ± 0.005 3.232 3.248 1.00
head math_integration_benchmark 3.241 ± 0.012 3.226 3.259 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.834 ± 0.006 2.827 2.848 1.00 ± 0.00
head memory_integration_benchmark 2.833 ± 0.008 2.822 2.844 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 3.206 ± 0.007 3.200 3.224 1.00
head operations_with_data_structures_benchmarks 3.241 ± 0.041 3.204 3.341 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.021 ± 0.003 1.018 1.025 1.00
head pedersen 1.022 ± 0.003 1.017 1.027 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.699 ± 0.004 1.691 1.706 1.00
head poseidon_integration_benchmark 1.718 ± 0.034 1.693 1.811 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.905 ± 0.009 3.895 3.926 1.00
head secp_integration_benchmark 3.905 ± 0.011 3.890 3.928 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 2.020 ± 0.006 2.009 2.028 1.00
head set_integration_benchmark 2.022 ± 0.008 2.010 2.032 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 10.083 ± 0.042 10.047 10.187 1.00
head uint256_integration_benchmark 10.139 ± 0.174 10.039 10.612 1.01 ± 0.02

Merged via the queue into main with commit 06f4c19 May 5, 2023
@Oppen Oppen deleted the CairoRunner-get_program branch May 5, 2023 15:49
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
* Add CairoRunner.get_program

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants