-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hints): add NewHint#50 #1045
Conversation
Benchmark Results for modified programs 🚀
|
Benchmark Results for unmodified programs 🚀
|
35bf536
to
fe34649
Compare
Rebased onto main after the merge of NewHint#47 |
Codecov Report
@@ Coverage Diff @@
## main #1045 +/- ##
========================================
Coverage 98.09% 98.09%
========================================
Files 84 84
Lines 33670 33810 +140
========================================
+ Hits 33027 33165 +138
- Misses 643 645 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
Comments addressed. They are part of the verbatim hint and need to be kept in. |
* Add NewHint#50 * Update changelog * Add TODO * Fix changelog PR number * Trigger recompilation for field_arithmetic.cairo * Fix: insert success_gx * Add border case tests * Change some assert_matches + Ok for assert + is_ok * Remove TODOs in field_arithmetic.cairo --------- Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com>
Depends on: #1030Description
This PR adds the missing hint NewHint#50, now known as
UINT256_GET_SQUARE_ROOT
. Also, allow trailing commas innon_continuous_ids_data
macro.