-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hints): add NewHint#49 #1043
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
April 24, 2023 20:00
MegaRedHand
added
the
whitelisted-hint
Implementation of hint on whitelist directory
label
Apr 24, 2023
Closed
fmoletta
approved these changes
Apr 24, 2023
MegaRedHand
force-pushed
the
newhint49-inv_mod_p_u256
branch
from
April 25, 2023 13:48
5c81fb9
to
10556b9
Compare
Rebased to main after merge of NewHint#47 |
Benchmark Results for unmodified programs 🚀
|
Codecov Report
@@ Coverage Diff @@
## main #1043 +/- ##
==========================================
- Coverage 98.08% 98.08% -0.01%
==========================================
Files 84 84
Lines 33459 33475 +16
==========================================
+ Hits 32818 32833 +15
- Misses 641 642 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This reverts commit ae30228.
Oppen
approved these changes
Apr 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Apr 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Apr 25, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Add tests for new hint * Refactor `inv_mod_p_uint512` to use new helpers * Add NewHint#49 * Update changelog * Trigger recompilation of fq_test.cairo * Revert "Trigger recompilation of fq_test.cairo" This reverts commit ae30228.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #1030Description
This PR adds the missing hint NewHint#49, now known as
INV_MOD_P_UINT256
.It also refactors
inv_mod_p_uint512
, so it uses recently addedUint512
andUint256
with theirpack
andsplit
methods.