Add 0.11 changes (#884)

* Add poseidon builtin (#875) * Add instance def * Add file * Add poseidon instance def to builtin instance def * Add Poseidon to BuiltinRunners * Add simple tests program * Prevent poseidon from being rejected by deserialize * Use modified version of starknet-crypto poseidon hash (need permute fn to be public in order to access full state * Add poseidon builtin impl + remove unreleased AddAssign usage * Fix EOF * Save a step * Add comment before unwrap * Clippy * Reorder files * Add comment * Use constants for cells * Add more test program * Add integration tests * test constant creation doesnt panic * Add tests * Fix failling tests * Use final values for POSEIDON_COMP_CONSTANTS and move calculation to test module * typo * Solve post-merge conflicts * Implement poseidon hints * Add file * Add tests for new hint * Clippy * Fix hint names * Solve post-merge conflicts * Add missing import * Use `starknet-crypto` for poseidon (#890) * ec_op changes 0.11 release (#876) * ec_op changes 0.11 release cairo_lang * Update src/vm/runners/builtin_runner/ec_op.rs Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com> * remove rc and change bigint to felt * debug cache * debug cache * change add_int implementation * cargo fmt --------- Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com> * [WIP] Update keccak-builtin (#873) * Add cache to keccak builtin * Temporaryly unhide recursive layout for debugging * Use same keccak method as the one used in keccak_utils * Make keccak builtin work * Fix visisbility * Small refactor * Refactor * Refactor * Add tests * Fix address management * Add test program * Clippy + Update tests * Remove unused import * Remove uneeded Rc * Make error less specific * Add integration test * Add proposed changes * Re-hide recursive layout * Update layouts to cairo-lang 0.11 release (#874) * update layouts to cairo-lang 0.11 release * update layout all * update benches and makefile * Add instance def * Add file * Add poseidon instance def to builtin instance def * Add Poseidon to BuiltinRunners * Add simple tests program * Prevent poseidon from being rejected by deserialize * Use modified version of starknet-crypto poseidon hash (need permute fn to be public in order to access full state * Add poseidon builtin impl + remove unreleased AddAssign usage * Fix EOF * Save a step * Add comment before unwrap * Clippy * Reorder files * reset run_benchmark script * Add comment * Use constants for cells * Add more test program * Add integration tests * test constant creation doesnt panic * Add tests * Fix failling tests * Use final values for POSEIDON_COMP_CONSTANTS and move calculation to test module * typo * Solve post-merge conflicts * Implement poseidon hints * Add file * Add tests for new hint * Clippy * allow dead code in default poseidon * remove wrong text * Update .github/workflows/rust.yml Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com> * Update src/types/instance_definitions/poseidon_instance_def.rs Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com> * Update src/types/instance_definitions/poseidon_instance_def.rs Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com> * Update src/types/instance_definitions/builtins_instance_def.rs Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com> * Update src/types/instance_definitions/builtins_instance_def.rs Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com> * Update src/types/instance_definitions/builtins_instance_def.rs Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com> --------- Co-authored-by: Federica <fedemoletta@hotmail.com> Co-authored-by: fmoletta <99273364+fmoletta@users.noreply.github.com> * Add new keccak hints + update import paths (#883) * Add cache to keccak builtin * Temporaryly unhide recursive layout for debugging * Use same keccak method as the one used in keccak_utils * Make keccak builtin work * Fix visisbility * Small refactor * Refactor * Refactor * Add tests * Fix address management * Add test program * Clippy + Update tests * Remove unused import * Remove uneeded Rc * Make error less specific * Add integration test * Add proposed changes * Add new hints * Add test program * Move constants * Add keccak hints; * Fix overflowing operation * Add more hints * Add unit tests * Add integration test * Update import paths in cairo programs used for testing * Update hints with new import paths * Add newline at end of file * Clippy * Clean imports * Re-hide recursive layout * Update src/hint_processor/builtin_hint_processor/keccak_utils.rs Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com> * Add suggested change + fix conflicts * Update src/hint_processor/builtin_hint_processor/keccak_utils.rs Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com> * Fix * Use u64 in split_n_bytes hints * Use starknet_with_keccak layout when running cairo-lang * Fix relative path in compare_vm_state script --------- Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com> * Remove typeguard pin * Run cairo-format * Fix program ruined by formatter * Fix wasm compatibility for newer files * Fix wasm compatibility for newer files * Fix wrong version * Fix syntax * Fix wasm compatibility * Tempfix for iai workflow * Fix workflow * Use the same layout for memory trace proof mode comparison * Add dynamic layout (#879) * Change instance def ratios to Option * Move builtin runner ratios to option * Modify methods to accomodate dynamic ratios * Misc fixes * Misc fixes * Fix wrong impl * Fix tests * Fix tests * Add dynamic layout * Fix wrong impl * Fix tests * Expose instances_per_component * Move get_used_cells_and_allocated_sizes to mod * Move get_allocated_memory_units to mod * Finnish prev tasks * Fix test * fix get_perm_range_check_limit * Fix get_range_check_usage * Fix test values * Fix workflows * Update Cargo.lock * Remove comment * [0.11] Add `SegmentArenaBuiltinRunner` (#913) * Change instance def ratios to Option * Move builtin runner ratios to option * Modify methods to accomodate dynamic ratios * Misc fixes * Misc fixes * Fix wrong impl * Fix tests * Fix tests * Add dynamic layout * Fix wrong impl * Fix tests * Expose instances_per_component * Move get_used_cells_and_allocated_sizes to mod * Move get_allocated_memory_units to mod * Finnish prev tasks * Fix test * Initial progress * Add builtin specific methods * Add SegmentArenaBuiltinRunner to BuiltinRunner enum * implement final_stack for segmen arena nuiltin runner * Add other methods * Integrate into runner * Remove error from initialize_segments * Fix comment * Add test * Add tests for segment arena builtin * Fix * fix get_perm_range_check_limit * Fix get_range_check_usage * Fix test values * expose program base for starknet reasons * Update src/vm/runners/builtin_runner/mod.rs Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com> * Fix build * Add nostd Vec import * Fix wasm import --------- Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com> Co-authored-by: Mario Rugiero <mrugiero@gmail.com> * Add suggested changes * Fix overriden run_benchmarks script * Add `program_segment_size` argument to `verify_secure_runner` & `run_from_entrypoint` (#928) * Change instance def ratios to Option * Move builtin runner ratios to option * Modify methods to accomodate dynamic ratios * Misc fixes * Misc fixes * Fix wrong impl * Fix tests * Fix tests * Add dynamic layout * Fix wrong impl * Fix tests * Expose instances_per_component * Move get_used_cells_and_allocated_sizes to mod * Move get_allocated_memory_units to mod * Finnish prev tasks * Fix test * Initial progress * Add builtin specific methods * Add SegmentArenaBuiltinRunner to BuiltinRunner enum * implement final_stack for segmen arena nuiltin runner * Add other methods * Integrate into runner * Remove error from initialize_segments * Fix comment * Add test * Add tests for segment arena builtin * Fix * fix get_perm_range_check_limit * Fix get_range_check_usage * Fix test values * expose program base for starknet reasons * Update src/vm/runners/builtin_runner/mod.rs Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com> * Add optional program_size argument to verify_secure_runner & run_from_entrypoint * Fix build * Add nostd Vec import * Fix wasm import * Expose get_segment_size (#934) --------- Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com> Co-authored-by: Mario Rugiero <mrugiero@gmail.com> * Fix typo * Add misc tests * Add misc tests * Add misc test * Add misc test * Add misc test * Expand misc test * Add wasm attr + misc test --------- Co-authored-by: Jonathan LEI <me@xjonathan.dev> Co-authored-by: Juan Rigada <62958725+Jrigada@users.noreply.github.com> Co-authored-by: Mario Rugiero <mario.rugiero@lambdaclass.com> Co-authored-by: Mario Rugiero <mrugiero@gmail.com>
lambdaclass · Apr 3, 2023 · 1fb4a72 · 1fb4a72
1 parent cdb5125
commit 1fb4a72
Show file tree

Hide file tree

Showing 77 changed files with 3,101 additions and 1,218 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Makefile b/Makefile
@@ -32,10 +32,10 @@ $(TEST_PROOF_DIR)/%.json: $(TEST_PROOF_DIR)/%.cairo
 	cairo-compile --cairo_path="$(TEST_PROOF_DIR):$(PROOF_BENCH_DIR)" $< --output $@ --proof_mode
 
 $(TEST_PROOF_DIR)/%.rs.trace $(TEST_PROOF_DIR)/%.rs.memory: $(TEST_PROOF_DIR)/%.json $(RELBIN)
-	cargo llvm-cov run -p cairo-vm-cli --release --no-report -- --layout all --proof_mode $< --trace_file $@ --memory_file $(@D)/$(*F).rs.memory
+	cargo llvm-cov run -p cairo-vm-cli --release --no-report -- --layout starknet_with_keccak --proof_mode $< --trace_file $@ --memory_file $(@D)/$(*F).rs.memory
 
 $(TEST_PROOF_DIR)/%.trace $(TEST_PROOF_DIR)/%.memory: $(TEST_PROOF_DIR)/%.json
-	cairo-run --layout all --proof_mode --program $< --trace_file $@ --memory_file $(@D)/$(*F).memory
+	cairo-run --layout starknet_with_keccak --proof_mode --program $< --trace_file $@ --memory_file $(@D)/$(*F).memory
 
 $(PROOF_BENCH_DIR)/%.json: $(PROOF_BENCH_DIR)/%.cairo
 	cairo-compile --cairo_path="$(TEST_PROOF_DIR):$(PROOF_BENCH_DIR)" $< --output $@ --proof_mode
@@ -68,10 +68,10 @@ $(TEST_DIR)/%.json: $(TEST_DIR)/%.cairo
 	cairo-compile --cairo_path="$(TEST_DIR):$(BENCH_DIR)" $< --output $@
 
 $(TEST_DIR)/%.rs.trace $(TEST_DIR)/%.rs.memory: $(TEST_DIR)/%.json $(RELBIN)
-	cargo llvm-cov run -p cairo-vm-cli --release --no-report -- --layout all $< --trace_file $@ --memory_file $(@D)/$(*F).rs.memory
+	cargo llvm-cov run -p cairo-vm-cli --release --no-report -- --layout all_cairo $< --trace_file $@ --memory_file $(@D)/$(*F).rs.memory
 
 $(TEST_DIR)/%.trace $(TEST_DIR)/%.memory: $(TEST_DIR)/%.json
-	cairo-run --layout all --program $< --trace_file $@ --memory_file $(@D)/$(*F).memory
+	cairo-run --layout starknet_with_keccak --program $< --trace_file $@ --memory_file $(@D)/$(*F).memory
 
 $(BENCH_DIR)/%.json: $(BENCH_DIR)/%.cairo
 	cairo-compile --cairo_path="$(TEST_DIR):$(BENCH_DIR)" $< --output $@

diff --git a/README.md b/README.md
@@ -94,7 +94,7 @@ cairo-compile cairo_programs/abs_value_array.cairo --output cairo_programs/abs_v
 To run a compiled .json program through the VM, call the executable giving it the path and name of the file to be executed. For example: 
 
 ```bash 
-target/release/cairo-rs-run cairo_programs/abs_value_array_compiled.json --layout all
+target/release/cairo-rs-run cairo_programs/abs_value_array_compiled.json --layout all_cairo
 ```
 The flag `--layout` determines which builtins can be used. More info about layouts [here](https://www.cairo-lang.org/docs/how_cairo_works/builtins.html#layouts).
 
@@ -109,7 +109,7 @@ cargo build --release
 
 cairo-compile cairo_programs/abs_value_array.cairo --output cairo_programs/abs_value_array_compiled.json
 
-target/release/cairo-rs-run cairo_programs/abs_value_array_compiled.json --layout all
+target/release/cairo-rs-run cairo_programs/abs_value_array_compiled.json --layout all_cairo
 ```
 ### Using hints
 
@@ -133,7 +133,7 @@ let program =
 ```rust
 let mut vm = VirtualMachine::new(false);
 
-let mut cairo_runner = CairoRunner::new(&program, "all", false);
+let mut cairo_runner = CairoRunner::new(&program, "all_cairo", false);
 
 let mut hint_processor = BuiltinHintProcessor::new_empty();
 

diff --git a/bench/criterion_benchmark.rs b/bench/criterion_benchmark.rs
@@ -35,7 +35,7 @@ const BENCH_PATH: &str = "cairo_programs/benchmarks/";
 pub fn criterion_benchmarks(c: &mut Criterion) {
     let mut hint_executor = BuiltinHintProcessor::new_empty();
     let cairo_run_config = cairo_vm::cairo_run::CairoRunConfig {
-        layout: "all",
+        layout: "all_cairo",
         ..cairo_vm::cairo_run::CairoRunConfig::default()
     };
     for benchmark_name in build_bench_strings() {

diff --git a/bench/iai_benchmark.rs b/bench/iai_benchmark.rs
@@ -58,7 +58,7 @@ macro_rules! iai_bench_expand_prog {
         fn $val() {
             let cairo_run_config = cairo_vm::cairo_run::CairoRunConfig {
                 trace_enabled: true,
-                layout: "all",
+                layout: "all_cairo",
                 //FIXME: we need to distinguish the proof compiled programs
                 //proof_mode: true,
                 secure_run: Some(true),

diff --git a/cairo-vm-cli/src/main.rs b/cairo-vm-cli/src/main.rs
@@ -41,7 +41,15 @@ struct Args {
 
 fn validate_layout(value: &str) -> Result<(), String> {
     match value {
-        "plain" | "small" | "dex" | "bitwise" | "perpetual_with_bitwise" | "all" => Ok(()),
+        "plain"
+        | "small"
+        | "dex"
+        | "starknet"
+        | "starknet_with_keccak"
+        | "recursive_large_output"
+        | "all_cairo"
+        | "all_solidity"
+        | "dynamic" => Ok(()),
         _ => Err(format!("{value} is not a valid layout")),
     }
 }
@@ -156,9 +164,11 @@ mod tests {
             "plain",
             "small",
             "dex",
-            "bitwise",
-            "perpetual_with_bitwise",
-            "all",
+            "starknet",
+            "starknet_with_keccak",
+            "recursive_large_output",
+            "all_cairo",
+            "all_solidity",
         ];
 
         for layout in valid_layouts {

diff --git a/cairo_programs/_keccak.cairo b/cairo_programs/_keccak.cairo
@@ -42,4 +42,3 @@ func main{output_ptr: felt*, range_check_ptr, bitwise_ptr: BitwiseBuiltin*}() {
 
     return ();
 }
-
diff --git a/cairo_programs/cairo_finalize_keccak.cairo b/cairo_programs/cairo_finalize_keccak.cairo
@@ -1,6 +1,6 @@
 %builtins range_check bitwise
 
-from starkware.cairo.common.cairo_keccak.keccak import keccak, finalize_keccak
+from starkware.cairo.common.cairo_keccak.keccak import cairo_keccak, finalize_keccak
 from starkware.cairo.common.uint256 import Uint256
 from starkware.cairo.common.cairo_builtins import BitwiseBuiltin
 from starkware.cairo.common.alloc import alloc
@@ -18,7 +18,7 @@ func main{range_check_ptr: felt, bitwise_ptr: BitwiseBuiltin*}() {
 
     let n_bytes = 16;
 
-    let (res: Uint256) = keccak{keccak_ptr=keccak_ptr}(inputs=inputs, n_bytes=n_bytes);
+    let (res: Uint256) = cairo_keccak{keccak_ptr=keccak_ptr}(inputs=inputs, n_bytes=n_bytes);
 
     assert res.low = 293431514620200399776069983710520819074;
     assert res.high = 317109767021952548743448767588473366791;

diff --git a/cairo_programs/chained_ec_op.cairo b/cairo_programs/chained_ec_op.cairo
@@ -5,7 +5,6 @@ from starkware.cairo.common.ec_point import EcPoint
 from starkware.cairo.common.ec import chained_ec_op
 from starkware.cairo.common.alloc import alloc
 
-
 func main{ec_op_ptr: EcOpBuiltin*}() {
     let p = EcPoint(
         0x6a4beaef5a93425b973179cdba0c9d42f30e01a5f1e2db73da0884b8d6756fc,
@@ -14,20 +13,20 @@ func main{ec_op_ptr: EcOpBuiltin*}() {
     let q1 = EcPoint(
         0x654fd7e67a123dd13868093b3b7777f1ffef596c2e324f25ceaf9146698482c,
         0x4fad269cbf860980e38768fe9cb6b0b9ab03ee3fe84cfde2eccce597c874fd8,
-        );
+    );
     let q2 = EcPoint(
         0x654fd7e67a123dd13868093b3b7777f1ffef596c2e324f25ceaf9146698482c,
         0x4fad269cbf860980e38768fe9cb6b0b9ab03ee3fe84cfde2eccce597c874fd8,
-        );
+    );
     let q3 = EcPoint(
         0x654fd7e67a123dd13868093b3b7777f1ffef596c2e324f25ceaf9146698482c,
         0x4fad269cbf860980e38768fe9cb6b0b9ab03ee3fe84cfde2eccce597c874fd8,
-        );
-    let q : EcPoint* = alloc();
+    );
+    let q: EcPoint* = alloc();
     assert q[0] = q1;
     assert q[1] = q2;
     assert q[2] = q3;
-    let m : felt* = alloc();
+    let m: felt* = alloc();
     assert m[0] = 34;
     assert m[1] = 34;
     assert m[2] = 34;

diff --git a/cairo_programs/common_signature.cairo b/cairo_programs/common_signature.cairo
@@ -4,6 +4,11 @@ from starkware.cairo.common.cairo_builtins import SignatureBuiltin
 from starkware.cairo.common.signature import verify_ecdsa_signature
 
 func main{ecdsa_ptr: SignatureBuiltin*}() {
-    verify_ecdsa_signature(2718, 1735102664668487605176656616876767369909409133946409161569774794110049207117, 3086480810278599376317923499561306189851900463386393948998357832163236918254, 598673427589502599949712887611119751108407514580626464031881322743364689811);
-    return();
+    verify_ecdsa_signature(
+        2718,
+        1735102664668487605176656616876767369909409133946409161569774794110049207117,
+        3086480810278599376317923499561306189851900463386393948998357832163236918254,
+        598673427589502599949712887611119751108407514580626464031881322743364689811,
+    );
+    return ();
 }
diff --git a/cairo_programs/dict.cairo b/cairo_programs/dict.cairo
@@ -21,7 +21,7 @@ func main() {
     let (local val6: felt) = dict_read{dict_ptr=my_dict}(key=11);
     assert val6 = 35;
     dict_write{dict_ptr=my_dict}(key=20, new_value=-5);
-    let (local val6 : felt) = dict_read{dict_ptr=my_dict}(key=20);
+    let (local val6: felt) = dict_read{dict_ptr=my_dict}(key=20);
     assert val6 = -5;
     return ();
 }
diff --git a/cairo_programs/dict_squash.cairo b/cairo_programs/dict_squash.cairo
@@ -22,11 +22,8 @@ func main{range_check_ptr}() -> () {
     let (squashed_dict_start, squashed_dict_end) = dict_squash{range_check_ptr=range_check_ptr}(
         dict_start, dict_end
     );
-    assert squashed_dict_end[0] = DictAccess(
-        key=0, prev_value=1, new_value=4);
-    assert squashed_dict_end[1] = DictAccess(
-        key=1, prev_value=10, new_value=25);
-    assert squashed_dict_end[2] = DictAccess(
-        key=2, prev_value=-2, new_value=-16);
+    assert squashed_dict_end[0] = DictAccess(key=0, prev_value=1, new_value=4);
+    assert squashed_dict_end[1] = DictAccess(key=1, prev_value=10, new_value=25);
+    assert squashed_dict_end[2] = DictAccess(key=2, prev_value=-2, new_value=-16);
     return ();
 }
diff --git a/cairo_programs/dict_update.cairo b/cairo_programs/dict_update.cairo
@@ -19,7 +19,7 @@ func main() {
     let (local val3: felt) = dict_read{dict_ptr=my_dict}(key=10);
     assert val3 = 22;
     dict_update{dict_ptr=my_dict}(key=10, prev_value=22, new_value=-8);
-    let (local val4 : felt) = dict_read{dict_ptr=my_dict}(key=10);
+    let (local val4: felt) = dict_read{dict_ptr=my_dict}(key=10);
     assert val4 = -8;
     return ();
 }
diff --git a/cairo_programs/ec_op.cairo b/cairo_programs/ec_op.cairo
@@ -4,7 +4,6 @@ from starkware.cairo.common.cairo_builtins import EcOpBuiltin
 from starkware.cairo.common.ec_point import EcPoint
 from starkware.cairo.common.ec import ec_op
 
-
 func main{ec_op_ptr: EcOpBuiltin*}() {
     let p = EcPoint(
         0x6a4beaef5a93425b973179cdba0c9d42f30e01a5f1e2db73da0884b8d6756fc,
@@ -14,7 +13,7 @@ func main{ec_op_ptr: EcOpBuiltin*}() {
     let q = EcPoint(
         0x654fd7e67a123dd13868093b3b7777f1ffef596c2e324f25ceaf9146698482c,
         0x4fad269cbf860980e38768fe9cb6b0b9ab03ee3fe84cfde2eccce597c874fd8,
-        );
+    );
     let (r) = ec_op(p, m, q);
     assert r.x = 108925483682366235368969256555281508851459278989259552980345066351008608800;
     assert r.y = 1592365885972480102953613056006596671718206128324372995731808913669237079419;

diff --git a/cairo_programs/example_program.cairo b/cairo_programs/example_program.cairo
@@ -32,7 +32,6 @@ func evaluate_fib() {
     return ();
 }
 
-
 func main{range_check_ptr: felt}() {
     let x = 64;
     tempvar y = 64 * 64;

diff --git a/cairo_programs/keccak_add_uint256.cairo b/cairo_programs/keccak_add_uint256.cairo
@@ -1,6 +1,6 @@
 %builtins output range_check bitwise
 
-from starkware.cairo.common.cairo_keccak.keccak import keccak_add_uint256
+from starkware.cairo.common.keccak_utils.keccak_utils import keccak_add_uint256
 from starkware.cairo.common.uint256 import Uint256
 from starkware.cairo.common.cairo_builtins import BitwiseBuiltin
 from starkware.cairo.common.alloc import alloc

diff --git a/cairo_programs/keccak_builtin.cairo b/cairo_programs/keccak_builtin.cairo
@@ -0,0 +1,18 @@
+%builtins keccak
+from starkware.cairo.common.cairo_builtins import KeccakBuiltin
+from starkware.cairo.common.keccak_state import KeccakBuiltinState
+
+func main{keccak_ptr: KeccakBuiltin*}() {
+    assert keccak_ptr[0].input = KeccakBuiltinState(1, 2, 3, 4, 5, 6, 7, 8);
+    let result = keccak_ptr[0].output;
+    let keccak_ptr = keccak_ptr + KeccakBuiltin.SIZE;
+    assert result.s0 = 528644516554364142278482415480021626364691973678134577961206;
+    assert result.s1 = 768681319646568210457759892191562701823009052229295869963057;
+    assert result.s2 = 1439835513376369408063324968379272676079109225238241190228026;
+    assert result.s3 = 1150396629165612276474514703759718478742374517669870754478270;
+    assert result.s4 = 1515147102575186161827863034255579930572231617017100845406254;
+    assert result.s5 = 1412568161597072838250338588041800080889949791225997426843744;
+    assert result.s6 = 982235455376248641031519404605670648838699214888770304613539;
+    assert result.s7 = 1339947803093378278438908448344904300127577306141693325151040;
+    return ();
+}
diff --git a/cairo_programs/keccak_integration_tests.cairo b/cairo_programs/keccak_integration_tests.cairo
@@ -1,7 +1,8 @@
 %builtins range_check bitwise
 
 from starkware.cairo.common.keccak import unsafe_keccak, unsafe_keccak_finalize, KeccakState
-from starkware.cairo.common.cairo_keccak.keccak import keccak_add_uint256, keccak, finalize_keccak
+from starkware.cairo.common.cairo_keccak.keccak import cairo_keccak, finalize_keccak
+from starkware.cairo.common.keccak_utils.keccak_utils import keccak_add_uint256
 from starkware.cairo.common.alloc import alloc
 from starkware.cairo.common.uint256 import Uint256
 from starkware.cairo.common.cairo_builtins import BitwiseBuiltin
@@ -56,7 +57,7 @@ func test_integration{range_check_ptr: felt, bitwise_ptr: BitwiseBuiltin*}(iter:
     let (keccak_ptr: felt*) = alloc();
     let keccak_ptr_start = keccak_ptr;
 
-    let res_2: Uint256 = keccak{keccak_ptr=keccak_ptr}(data_3, 16);
+    let res_2: Uint256 = cairo_keccak{keccak_ptr=keccak_ptr}(data_3, 16);
 
     finalize_keccak(keccak_ptr_start=keccak_ptr_start, keccak_ptr_end=keccak_ptr);
 

diff --git a/cairo_programs/keccak_uint256.cairo b/cairo_programs/keccak_uint256.cairo
@@ -0,0 +1,19 @@
+%builtins range_check bitwise keccak
+from starkware.cairo.common.cairo_builtins import KeccakBuiltin, BitwiseBuiltin
+from starkware.cairo.common.builtin_keccak.keccak import keccak_uint256s
+from starkware.cairo.common.alloc import alloc
+from starkware.cairo.common.uint256 import Uint256
+
+func main{range_check_ptr, bitwise_ptr: BitwiseBuiltin*, keccak_ptr: KeccakBuiltin*}() {
+    let elements: Uint256* = alloc();
+    assert elements[0] = Uint256(713458135386519, 18359173571);
+    assert elements[1] = Uint256(1536741637546373185, 84357893467438914);
+    assert elements[2] = Uint256(2842949328439284983294, 39248298942938492384);
+    assert elements[3] = Uint256(27518568234293478923754395731931, 981587843715983274);
+    assert elements[4] = Uint256(326848123647324823482, 93453458349589345);
+    let (res) = keccak_uint256s(5, elements);
+    assert res.high = 23012215180764429403047187376747988760;
+    assert res.low = 13431206634823648732212765105043225161;
+
+    return ();
+}
diff --git a/cairo_programs/packed_sha256.cairo b/cairo_programs/packed_sha256.cairo
@@ -10,8 +10,9 @@ const ALL_ONES = 2 ** 251 - 1;
 // Pack the different instances with offsets of 35 bits. This is the maximal possible offset for
 // 7 32-bit words and it allows space for carry bits in integer addition operations (up to
 // 8 summands).
-const SHIFTS = 1 + 2 ** 35 + 2 ** (35 * 2) + 2 ** (35 * 3) + 2 ** (35 * 4) + 2 ** (35 * 5) +
-    2 ** (35 * 6);
+const SHIFTS = 1 + 2 ** 35 + 2 ** (35 * 2) + 2 ** (35 * 3) + 2 ** (35 * 4) + 2 ** (35 * 5) + 2 ** (
+    35 * 6
+);
 
 // Given an array of size 16, extends it to the message schedule array (of size 64) by writing
 // 48 more values.
@@ -426,8 +427,9 @@ func _finalize_sha256_inner{range_check_ptr, bitwise_ptr: BitwiseBuiltin*}(
     tempvar x6 = sha256_ptr[6 * SHA256_INSTANCE_SIZE];
     assert [range_check_ptr + 12] = x6;
     assert [range_check_ptr + 13] = MAX_VALUE - x6;
-    assert message[0] = x0 + 2 ** 35 * x1 + 2 ** (35 * 2) * x2 + 2 ** (35 * 3) * x3 +
-        2 ** (35 * 4) * x4 + 2 ** (35 * 5) * x5 + 2 ** (35 * 6) * x6;
+    assert message[0] = x0 + 2 ** 35 * x1 + 2 ** (35 * 2) * x2 + 2 ** (35 * 3) * x3 + 2 ** (
+        35 * 4
+    ) * x4 + 2 ** (35 * 5) * x5 + 2 ** (35 * 6) * x6;
 
     tempvar message = message + 1;
     tempvar sha256_ptr = sha256_ptr + 1;
@@ -464,8 +466,9 @@ func _finalize_sha256_inner{range_check_ptr, bitwise_ptr: BitwiseBuiltin*}(
     tempvar x6 = sha256_ptr[6 * SHA256_INSTANCE_SIZE];
     assert [range_check_ptr + 12] = x6;
     assert [range_check_ptr + 13] = MAX_VALUE - x6;
-    assert input_state[0] = x0 + 2 ** 35 * x1 + 2 ** (35 * 2) * x2 + 2 ** (35 * 3) * x3 +
-        2 ** (35 * 4) * x4 + 2 ** (35 * 5) * x5 + 2 ** (35 * 6) * x6;
+    assert input_state[0] = x0 + 2 ** 35 * x1 + 2 ** (35 * 2) * x2 + 2 ** (35 * 3) * x3 + 2 ** (
+        35 * 4
+    ) * x4 + 2 ** (35 * 5) * x5 + 2 ** (35 * 6) * x6;
 
     tempvar input_state = input_state + 1;
     tempvar sha256_ptr = sha256_ptr + 1;
@@ -510,8 +513,9 @@ func _finalize_sha256_inner{range_check_ptr, bitwise_ptr: BitwiseBuiltin*}(
     tempvar x6 = sha256_ptr[6 * SHA256_INSTANCE_SIZE];
     assert [range_check_ptr + 12] = x6;
     assert [range_check_ptr + 13] = MAX_VALUE - x6;
-    assert outputs[0] = x0 + 2 ** 35 * x1 + 2 ** (35 * 2) * x2 + 2 ** (35 * 3) * x3 +
-        2 ** (35 * 4) * x4 + 2 ** (35 * 5) * x5 + 2 ** (35 * 6) * x6;
+    assert outputs[0] = x0 + 2 ** 35 * x1 + 2 ** (35 * 2) * x2 + 2 ** (35 * 3) * x3 + 2 ** (
+        35 * 4
+    ) * x4 + 2 ** (35 * 5) * x5 + 2 ** (35 * 6) * x6;
 
     tempvar outputs = outputs + 1;
     tempvar sha256_ptr = sha256_ptr + 1;

diff --git a/cairo_programs/poseidon_builtin.cairo b/cairo_programs/poseidon_builtin.cairo
@@ -0,0 +1,13 @@
+%builtins poseidon
+from starkware.cairo.common.cairo_builtins import PoseidonBuiltin
+from starkware.cairo.common.poseidon_state import PoseidonBuiltinState
+
+func main{poseidon_ptr: PoseidonBuiltin*}() {
+    assert poseidon_ptr[0].input = PoseidonBuiltinState(1, 2, 3);
+    let result = poseidon_ptr[0].output;
+    let poseidon_ptr = poseidon_ptr + PoseidonBuiltin.SIZE;
+    assert result.s0 = 442682200349489646213731521593476982257703159825582578145778919623645026501;
+    assert result.s1 = 2233832504250924383748553933071188903279928981104663696710686541536735838182;
+    assert result.s2 = 2512222140811166287287541003826449032093371832913959128171347018667852712082;
+    return ();
+}
diff --git a/cairo_programs/poseidon_hash.cairo b/cairo_programs/poseidon_hash.cairo
@@ -0,0 +1,30 @@
+%builtins poseidon
+from starkware.cairo.common.cairo_builtins import PoseidonBuiltin
+from starkware.cairo.common.poseidon_state import PoseidonBuiltinState
+from starkware.cairo.common.builtin_poseidon.poseidon import (
+    poseidon_hash,
+    poseidon_hash_single,
+    poseidon_hash_many,
+)
+from starkware.cairo.common.alloc import alloc
+
+func main{poseidon_ptr: PoseidonBuiltin*}() {
+    // Hash one
+    let (x) = poseidon_hash_single(
+        218676008889449692916464780911713710628115973574242889792891157041292792362
+    );
+    assert x = 2835120893146788752888137145656423078969524407843035783270702964188823073934;
+    // Hash two
+    let (y) = poseidon_hash(1253795, 18540013156130945068);
+    assert y = 37282360750367388068593128053386029947772104009544220786084510532118246655;
+    // Hash five
+    let felts: felt* = alloc();
+    assert felts[0] = 84175983715088675913672849362079546;
+    assert felts[1] = 9384720329467203286234076408512594689579283578028960384690;
+    assert felts[2] = 291883989128409324823849293040390493094093;
+    assert felts[3] = 5849589438543859348593485948598349584395839402940940290490324;
+    assert felts[4] = 1836254780028456372728992049476335424263474849;
+    let (z) = poseidon_hash_many(5, felts);
+    assert z = 47102513329160951064697157194713013753695317629154835326726810042406974264;
+    return ();
+}
diff --git a/cairo_programs/recover_y.cairo b/cairo_programs/recover_y.cairo
@@ -4,7 +4,6 @@ from starkware.cairo.common.cairo_builtins import EcOpBuiltin
 from starkware.cairo.common.ec_point import EcPoint
 from starkware.cairo.common.ec import recover_y
 
-
 func main{ec_op_ptr: EcOpBuiltin*}() {
     let x = 0x6a4beaef5a93425b973179cdba0c9d42f30e01a5f1e2db73da0884b8d6756fc;
     let r: EcPoint = recover_y(x);
Original file line number	Diff line number	Diff line change
Expand Up		@@ -42,4 +42,3 @@ func main{output_ptr: felt, range_check_ptr, bitwise_ptr: BitwiseBuiltin}() {

		return ();
		}